From 059b18ea3154870de77cd62b201d32f8b247a598 Mon Sep 17 00:00:00 2001 From: Ryan Leung Date: Tue, 6 Aug 2024 19:31:47 +0800 Subject: [PATCH] address the comment Signed-off-by: Ryan Leung --- pkg/mcs/resourcemanager/server/server.go | 1 - pkg/mcs/scheduling/server/server.go | 1 - pkg/mcs/server/server.go | 2 +- pkg/mcs/tso/server/server.go | 1 - pkg/mcs/utils/util.go | 1 + 5 files changed, 2 insertions(+), 4 deletions(-) diff --git a/pkg/mcs/resourcemanager/server/server.go b/pkg/mcs/resourcemanager/server/server.go index 7b76cb10fac..c8ccfab0333 100644 --- a/pkg/mcs/resourcemanager/server/server.go +++ b/pkg/mcs/resourcemanager/server/server.go @@ -113,7 +113,6 @@ func (s *Server) Run() (err error) { return err } - // register if s.clusterID, s.serviceID, s.serviceRegister, err = utils.Register(s, constant.ResourceManagerServiceName); err != nil { return err } diff --git a/pkg/mcs/scheduling/server/server.go b/pkg/mcs/scheduling/server/server.go index 56adafe0d48..6ec4e444d6d 100644 --- a/pkg/mcs/scheduling/server/server.go +++ b/pkg/mcs/scheduling/server/server.go @@ -149,7 +149,6 @@ func (s *Server) Run() (err error) { return err } - // register if s.clusterID, s.serviceID, s.serviceRegister, err = utils.Register(s, constant.SchedulingServiceName); err != nil { return err } diff --git a/pkg/mcs/server/server.go b/pkg/mcs/server/server.go index 7b8cee79ae6..31b6c2c76cb 100644 --- a/pkg/mcs/server/server.go +++ b/pkg/mcs/server/server.go @@ -100,7 +100,7 @@ func (bs *BaseServer) SetEtcdClient(etcdClient *clientv3.Client) { bs.etcdClient = etcdClient } -// SetETCDClient sets the etcd client. +// GetEtcdClient returns the etcd client. func (bs *BaseServer) GetEtcdClient() *clientv3.Client { return bs.etcdClient } diff --git a/pkg/mcs/tso/server/server.go b/pkg/mcs/tso/server/server.go index 3a7534f4800..0134a65dfd0 100644 --- a/pkg/mcs/tso/server/server.go +++ b/pkg/mcs/tso/server/server.go @@ -156,7 +156,6 @@ func (s *Server) Run() (err error) { return err } - // register if s.clusterID, s.serviceID, s.serviceRegister, err = utils.Register(s, constant.TSOServiceName); err != nil { return err } diff --git a/pkg/mcs/utils/util.go b/pkg/mcs/utils/util.go index 6988b7f5b17..fa76aadc1e8 100644 --- a/pkg/mcs/utils/util.go +++ b/pkg/mcs/utils/util.go @@ -278,6 +278,7 @@ func StopGRPCServer(s server) { } } +// Register registers the service. func Register(s server, serviceName string) (uint64, *discovery.ServiceRegistryEntry, *discovery.ServiceRegister, error) { var ( clusterID uint64