Skip to content
This repository has been archived by the owner on Aug 3, 2022. It is now read-only.

Control_interface: Uninitialized yaw used in pathToLocalCallback #103

Open
mehmetkillioglu opened this issue Dec 2, 2021 · 0 comments
Open

Comments

@mehmetkillioglu
Copy link
Contributor

This issue is found during coverity scans.

In line 910, the gps_waypoint_t is constructed, but the yaw angle is never initialized.

control_interface/src/control_interface.cpp#L910

In #L915, this variable is passed to globalToLocal method to transform waypoint.

In this method, #L106 is trying to access yaw angle, which was never initialized.

There were some issues recently with the drone testing. After the drone launches, sometimes it rotates to wrong yaw angle instead of facing the desired orientation. This might be the cause of that issue.

The HTML formatted covariance test results can be found in control_interface_issues.zip. Extract, and open the errs/index.html. This mentioned issue is ID 80.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant