Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When quitting the container, don't set third-party-card fan-reaction to enable. #54

Open
ThatCoffeeGuy opened this issue Mar 20, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ThatCoffeeGuy
Copy link

As in the title. When I start shutting off the server, it skyrockets because when the docker container exists, it sets back the default enabled value for the third-party-card fan-reaction.. I would love a flag for this. If I have the time, I'll try to make it myself, until that, it's an idea here.

@ThatCoffeeGuy
Copy link
Author

ThatCoffeeGuy commented Mar 21, 2023

So basically

function gracefull_exit () {
  apply_Dell_fan_control_profile
  enable_third_party_PCIe_card_Dell_default_cooling_response
  echo "/!\ WARNING /!\ Container stopped, Dell default dynamic fan control profile applied for safety."
  exit 0
}

|
|
V

function gracefull_exit () {
  apply_Dell_fan_control_profile
   if $DISABLE_THIRD_PARTY_PCIE_CARD_DELL_DEFAULT_COOLING_RESPONSE_AFTER_CONTAINER_EXIT
  then
  disable_third_party_PCIe_card_Dell_default_cooling_response
  else
  enable_third_party_PCIe_card_Dell_default_cooling_response
  echo "/!\ WARNING /!\ Container stopped, Dell default dynamic fan control profile applied for safety."
  exit 0
}

Should do the trick. I suppose we should introduce an environmental variable ($DISABLE_THIRD_PARTY_PCIE_CARD_DELL_DEFAULT_COOLING_RESPONSE_AFTER_CONTAINER_EXIT), so this behavior can be controlled.

@tigerblue77 tigerblue77 added enhancement New feature or request good first issue Good for newcomers labels Apr 4, 2023
@tigerblue77 tigerblue77 self-assigned this Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants