Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(voxel_grid_covariance_omp): remove cin in radius search #69

Conversation

BaronYSYong
Copy link

@BaronYSYong BaronYSYong commented Nov 6, 2024

Description

Why

  • To ensure std:cin will not be called every time running radiusSearch in ndt_omp

What

  • Remove std:cin from radiusSearch in ndt_omp

Related links

Tests performed

  • The only changes in this PR is to remove std:cin in radiusSearch, which will not affect functionality and performance of localization.
  • From the simulation, the vehicle is moving properly without any emergency error.

Peek 2024-11-14 11-09

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Copy link

@peeeechi peeeechi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your response. LGTM! !
I approve

Copy link

@1222-takeshi 1222-takeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
FYI related PR

@BaronYSYong BaronYSYong changed the title voxel_grid_covariance_omp.h: remove cin in radiusSearch fix(voxel_grid_covariance_omp): remove cin in radius search Nov 14, 2024
@yn-mrse yn-mrse merged commit 5972635 into tier4:x1eve/beta/v0.0.0 Nov 14, 2024
8 checks passed
@BaronYSYong BaronYSYong deleted the refactor/remove-cin-in-radius-search branch November 14, 2024 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants