-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ndt_omp): prefix with autoware_ #68
Conversation
034410a
to
e3828f1
Compare
f6c27e6
to
5283728
Compare
Signed-off-by: Esteve Fernandez <[email protected]>
707e5be
to
6fb0c4b
Compare
@SakodaShintaro can you review this PR when you have a moment? Thanks. |
Thank you for the pull request. |
@esteve |
@SakodaShintaro I spoke about this with @mitsudome-r and @xmfcx yesterday during the ASWG meeting and they were ok with adding the prefix to |
@esteve I had a discussion with TIER IV localization team regarding the naming. First of all, they are okay with adding autoware_ prefix to the package. However, they were a bit worried about having a similar package registered to ROS Buildfarm with just adding a prefix to the package. Are there any examples where there is a forked package released as a binary with a different name in ROS Buildfarm? |
I think that one option could be to abandon this repository and move all the necessary code into the |
AFAIK the only package that depends on |
@SakodaShintaro I can move the code from here to |
There are no particular changes we want to make in the near future in this repository, so I think it will be fine to proceed with the archive and move flow. I will discuss this with the team. Additionally, there is currently a pull request on autoware.universe to add a prefix to |
@SakodaShintaro Thanks! |
I created a pull request in autoware.universe to visualize the necessary changes: |
autowarefoundation/autoware.universe#8912 has been merged. |
This PR prefixes
ndt_omp
withautoware_
See autowarefoundation/autoware#4569