refactor: organized ndt params #43

SakodaShintaro · 2024-03-14T09:09:59Z

Some of the parameters are duplicated both as direct member variables and as member variables of a parameter structure, so I deleted direct member variables.

The scores are perfectly the same.
https://github.com/tier4/ndt_omp/actions/runs/8278127568/job/22649848431

Signed-off-by: Shintaro Sakoda <[email protected]>

SakodaShintaro · 2024-03-14T09:18:47Z

@anhnv3991
It have been confirmed that "The scores are perfectly the same.", so there is no need to confirm whether it works in your environment, just simply check the changes and approve if OK.

anhnv3991

@SakodaShintaro LGTM!

* Organized ndt params Signed-off-by: Shintaro Sakoda <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: Shintaro Sakoda <[email protected]> Co-authored-by: SakodaShintaro <[email protected]>

* Coding Signed-off-by: anhnv3991 <[email protected]> * Rearrange the code to avoid duplicated processing Signed-off-by: anhnv3991 <[email protected]> * style(pre-commit): autofix * Updated reference/result.csv Signed-off-by: Shintaro Sakoda <[email protected]> * A minor fix Signed-off-by: Shintaro Sakoda <[email protected]> * refactor: organized ndt params (#43) * Organized ndt params Signed-off-by: Shintaro Sakoda <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: Shintaro Sakoda <[email protected]> Co-authored-by: SakodaShintaro <[email protected]> * Coding Signed-off-by: anhnv3991 <[email protected]> * Fixed conflicts after rebasing Signed-off-by: anhnv3991 <[email protected]> * Coding Signed-off-by: anhnv3991 <[email protected]> * Coding Signed-off-by: anhnv3991 <[email protected]> * Fixed some bugs Signed-off-by: anhnv3991 <[email protected]> * style(pre-commit): autofix * Fixed to run workflow Signed-off-by: Shintaro Sakoda <[email protected]> --------- Signed-off-by: anhnv3991 <[email protected]> Signed-off-by: Shintaro Sakoda <[email protected]> Co-authored-by: anhnv3991 <[email protected]> Co-authored-by: Shintaro Sakoda <[email protected]> Co-authored-by: SakodaShintaro <[email protected]> Co-authored-by: SakodaShintaro <[email protected]>

* Organized ndt params Signed-off-by: Shintaro Sakoda <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: Shintaro Sakoda <[email protected]> Co-authored-by: SakodaShintaro <[email protected]>

* Coding Signed-off-by: anhnv3991 <[email protected]> * Rearrange the code to avoid duplicated processing Signed-off-by: anhnv3991 <[email protected]> * style(pre-commit): autofix * Updated reference/result.csv Signed-off-by: Shintaro Sakoda <[email protected]> * A minor fix Signed-off-by: Shintaro Sakoda <[email protected]> * refactor: organized ndt params (#43) * Organized ndt params Signed-off-by: Shintaro Sakoda <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: Shintaro Sakoda <[email protected]> Co-authored-by: SakodaShintaro <[email protected]> * Coding Signed-off-by: anhnv3991 <[email protected]> * Fixed conflicts after rebasing Signed-off-by: anhnv3991 <[email protected]> * Coding Signed-off-by: anhnv3991 <[email protected]> * Coding Signed-off-by: anhnv3991 <[email protected]> * Fixed some bugs Signed-off-by: anhnv3991 <[email protected]> * style(pre-commit): autofix * Fixed to run workflow Signed-off-by: Shintaro Sakoda <[email protected]> --------- Signed-off-by: anhnv3991 <[email protected]> Signed-off-by: Shintaro Sakoda <[email protected]> Co-authored-by: anhnv3991 <[email protected]> Co-authored-by: Shintaro Sakoda <[email protected]> Co-authored-by: SakodaShintaro <[email protected]> Co-authored-by: SakodaShintaro <[email protected]>

* Refactoring multigrid_ndt_omp Signed-off-by: anhnv3991 <[email protected]> * Refactored multigrid_ndt_omp Signed-off-by: anhnv3991 <[email protected]> * style(pre-commit): autofix * Fixed to build Signed-off-by: Shintaro Sakoda <[email protected]> * Removed line breaks Signed-off-by: Shintaro Sakoda <[email protected]> * For reference, this should be discared later Signed-off-by: anhnv3991 <[email protected]> * Testing Signed-off-by: anhnv3991 <[email protected]> * Clean up a bit Signed-off-by: anhnv3991 <[email protected]> * Clean up a bit Signed-off-by: anhnv3991 <[email protected]> * style(pre-commit): autofix * refactor: organized ndt params (#43) * Organized ndt params Signed-off-by: Shintaro Sakoda <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: Shintaro Sakoda <[email protected]> Co-authored-by: SakodaShintaro <[email protected]> * Speed up multigrid NDT align (#41) * Coding Signed-off-by: anhnv3991 <[email protected]> * Rearrange the code to avoid duplicated processing Signed-off-by: anhnv3991 <[email protected]> * style(pre-commit): autofix * Updated reference/result.csv Signed-off-by: Shintaro Sakoda <[email protected]> * A minor fix Signed-off-by: Shintaro Sakoda <[email protected]> * refactor: organized ndt params (#43) * Organized ndt params Signed-off-by: Shintaro Sakoda <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: Shintaro Sakoda <[email protected]> Co-authored-by: SakodaShintaro <[email protected]> * Coding Signed-off-by: anhnv3991 <[email protected]> * Fixed conflicts after rebasing Signed-off-by: anhnv3991 <[email protected]> * Coding Signed-off-by: anhnv3991 <[email protected]> * Coding Signed-off-by: anhnv3991 <[email protected]> * Fixed some bugs Signed-off-by: anhnv3991 <[email protected]> * style(pre-commit): autofix * Fixed to run workflow Signed-off-by: Shintaro Sakoda <[email protected]> --------- Signed-off-by: anhnv3991 <[email protected]> Signed-off-by: Shintaro Sakoda <[email protected]> Co-authored-by: anhnv3991 <[email protected]> Co-authored-by: Shintaro Sakoda <[email protected]> Co-authored-by: SakodaShintaro <[email protected]> Co-authored-by: SakodaShintaro <[email protected]> * fix: add tp to regression test (#44) * Added tp_score to regression_test Signed-off-by: Shintaro Sakoda <[email protected]> * Updated result.csv by result of GitHub Actions Signed-off-by: Shintaro Sakoda <[email protected]> * Updated by the latest result Signed-off-by: Shintaro Sakoda <[email protected]> --------- Signed-off-by: Shintaro Sakoda <[email protected]> * fix: add a param use line search (#46) * Added a parameter "use_line_search" Signed-off-by: Shintaro Sakoda <[email protected]> * Added default value use_line_search=false Signed-off-by: Shintaro Sakoda <[email protected]> --------- Signed-off-by: Shintaro Sakoda <[email protected]> * Refactoring multigrid_ndt_omp Signed-off-by: anhnv3991 <[email protected]> * Refactored multigrid_ndt_omp Signed-off-by: anhnv3991 <[email protected]> * style(pre-commit): autofix * Removed line breaks Signed-off-by: Shintaro Sakoda <[email protected]> * For reference, this should be discared later Signed-off-by: anhnv3991 <[email protected]> * Testing Signed-off-by: anhnv3991 <[email protected]> * Clean up a bit Signed-off-by: anhnv3991 <[email protected]> * Clean up a bit Signed-off-by: anhnv3991 <[email protected]> * Debugging Signed-off-by: anhnv3991 <[email protected]> * Fixed a bug Signed-off-by: anhnv3991 <[email protected]> * style(pre-commit): autofix * Fixed build error Signed-off-by: anhnv3991 <[email protected]> * Updated result.csv Signed-off-by: Shintaro SAKODA <[email protected]> --------- Signed-off-by: anhnv3991 <[email protected]> Signed-off-by: Shintaro Sakoda <[email protected]> Signed-off-by: Shintaro SAKODA <[email protected]> Co-authored-by: anhnv3991 <[email protected]> Co-authored-by: SakodaShintaro <[email protected]> Co-authored-by: Shintaro Sakoda <[email protected]> Co-authored-by: SakodaShintaro <[email protected]>

* Coding Signed-off-by: anhnv3991 <[email protected]> * Rearrange the code to avoid duplicated processing Signed-off-by: anhnv3991 <[email protected]> * style(pre-commit): autofix * Added multithread voxel grid build Signed-off-by: anhnv3991 <[email protected]> * style(pre-commit): autofix * Fixed Signed-off-by: anhnv3991 <[email protected]> * Fixed wrong tmp_score usage Signed-off-by: anhnv3991 <[email protected]> * Refactor multigrid_ndt_omp (#32) * Refactoring multigrid_ndt_omp Signed-off-by: anhnv3991 <[email protected]> * Refactored multigrid_ndt_omp Signed-off-by: anhnv3991 <[email protected]> * style(pre-commit): autofix * Fixed to build Signed-off-by: Shintaro Sakoda <[email protected]> * Removed line breaks Signed-off-by: Shintaro Sakoda <[email protected]> * For reference, this should be discared later Signed-off-by: anhnv3991 <[email protected]> * Testing Signed-off-by: anhnv3991 <[email protected]> * Clean up a bit Signed-off-by: anhnv3991 <[email protected]> * Clean up a bit Signed-off-by: anhnv3991 <[email protected]> * style(pre-commit): autofix * refactor: organized ndt params (#43) * Organized ndt params Signed-off-by: Shintaro Sakoda <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: Shintaro Sakoda <[email protected]> Co-authored-by: SakodaShintaro <[email protected]> * Speed up multigrid NDT align (#41) * Coding Signed-off-by: anhnv3991 <[email protected]> * Rearrange the code to avoid duplicated processing Signed-off-by: anhnv3991 <[email protected]> * style(pre-commit): autofix * Updated reference/result.csv Signed-off-by: Shintaro Sakoda <[email protected]> * A minor fix Signed-off-by: Shintaro Sakoda <[email protected]> * refactor: organized ndt params (#43) * Organized ndt params Signed-off-by: Shintaro Sakoda <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: Shintaro Sakoda <[email protected]> Co-authored-by: SakodaShintaro <[email protected]> * Coding Signed-off-by: anhnv3991 <[email protected]> * Fixed conflicts after rebasing Signed-off-by: anhnv3991 <[email protected]> * Coding Signed-off-by: anhnv3991 <[email protected]> * Coding Signed-off-by: anhnv3991 <[email protected]> * Fixed some bugs Signed-off-by: anhnv3991 <[email protected]> * style(pre-commit): autofix * Fixed to run workflow Signed-off-by: Shintaro Sakoda <[email protected]> --------- Signed-off-by: anhnv3991 <[email protected]> Signed-off-by: Shintaro Sakoda <[email protected]> Co-authored-by: anhnv3991 <[email protected]> Co-authored-by: Shintaro Sakoda <[email protected]> Co-authored-by: SakodaShintaro <[email protected]> Co-authored-by: SakodaShintaro <[email protected]> * fix: add tp to regression test (#44) * Added tp_score to regression_test Signed-off-by: Shintaro Sakoda <[email protected]> * Updated result.csv by result of GitHub Actions Signed-off-by: Shintaro Sakoda <[email protected]> * Updated by the latest result Signed-off-by: Shintaro Sakoda <[email protected]> --------- Signed-off-by: Shintaro Sakoda <[email protected]> * fix: add a param use line search (#46) * Added a parameter "use_line_search" Signed-off-by: Shintaro Sakoda <[email protected]> * Added default value use_line_search=false Signed-off-by: Shintaro Sakoda <[email protected]> --------- Signed-off-by: Shintaro Sakoda <[email protected]> * Refactoring multigrid_ndt_omp Signed-off-by: anhnv3991 <[email protected]> * Refactored multigrid_ndt_omp Signed-off-by: anhnv3991 <[email protected]> * style(pre-commit): autofix * Removed line breaks Signed-off-by: Shintaro Sakoda <[email protected]> * For reference, this should be discared later Signed-off-by: anhnv3991 <[email protected]> * Testing Signed-off-by: anhnv3991 <[email protected]> * Clean up a bit Signed-off-by: anhnv3991 <[email protected]> * Clean up a bit Signed-off-by: anhnv3991 <[email protected]> * Debugging Signed-off-by: anhnv3991 <[email protected]> * Fixed a bug Signed-off-by: anhnv3991 <[email protected]> * style(pre-commit): autofix * Fixed build error Signed-off-by: anhnv3991 <[email protected]> * Updated result.csv Signed-off-by: Shintaro SAKODA <[email protected]> --------- Signed-off-by: anhnv3991 <[email protected]> Signed-off-by: Shintaro Sakoda <[email protected]> Signed-off-by: Shintaro SAKODA <[email protected]> Co-authored-by: anhnv3991 <[email protected]> Co-authored-by: SakodaShintaro <[email protected]> Co-authored-by: Shintaro Sakoda <[email protected]> Co-authored-by: SakodaShintaro <[email protected]> * Coding Signed-off-by: anhnv3991 <[email protected]> * Rearrange the code to avoid duplicated processing Signed-off-by: anhnv3991 <[email protected]> * style(pre-commit): autofix * Added multithread voxel grid build Signed-off-by: anhnv3991 <[email protected]> * Fixed build error Signed-off-by: anhnv3991 <[email protected]> * Fixed build errors Signed-off-by: anhnv3991 <[email protected]> * Applied clang Signed-off-by: anhnv3991 <[email protected]> * Added line break at the end of .h and .hpp files Signed-off-by: anhnv3991 <[email protected]> * style(pre-commit): autofix * Removed unused include and comments Signed-off-by: anhnv3991 <[email protected]> * Removed unused include and fixed a segmentation fault when sync in setThreadNum Signed-off-by: anhnv3991 <[email protected]> * Fix build error when compare int with size_t Signed-off-by: anhnv3991 <[email protected]> * Fix build error when compare int with size_t Signed-off-by: anhnv3991 <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: anhnv3991 <[email protected]> Signed-off-by: Shintaro Sakoda <[email protected]> Signed-off-by: Shintaro SAKODA <[email protected]> Co-authored-by: anhnv3991 <[email protected]> Co-authored-by: SakodaShintaro <[email protected]> Co-authored-by: Shintaro Sakoda <[email protected]> Co-authored-by: SakodaShintaro <[email protected]>

Organized ndt params

385521d

Signed-off-by: Shintaro Sakoda <[email protected]>

SakodaShintaro requested a review from anhnv3991 March 14, 2024 09:09

SakodaShintaro self-assigned this Mar 14, 2024

style(pre-commit): autofix

a23e2cd

SakodaShintaro marked this pull request as ready for review March 14, 2024 09:14

SakodaShintaro mentioned this pull request Mar 14, 2024

Refactor multigrid_ndt_omp #32

Merged

anhnv3991 approved these changes Mar 15, 2024

View reviewed changes

SakodaShintaro merged commit 39754a6 into tier4/main Mar 15, 2024

SakodaShintaro deleted the refactor/organize_ndt_param branch March 15, 2024 07:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: organized ndt params #43

refactor: organized ndt params #43

SakodaShintaro commented Mar 14, 2024 •

edited

Loading

SakodaShintaro commented Mar 14, 2024

anhnv3991 left a comment

refactor: organized ndt params #43

refactor: organized ndt params #43

Conversation

SakodaShintaro commented Mar 14, 2024 • edited Loading

SakodaShintaro commented Mar 14, 2024

anhnv3991 left a comment

Choose a reason for hiding this comment

SakodaShintaro commented Mar 14, 2024 •

edited

Loading