Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed incorrect arguments in rclcpp_service_callback_added #289

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

miyakoshi-dev
Copy link
Contributor

@miyakoshi-dev miyakoshi-dev commented Jun 11, 2024

Description

fixed incorrect arguments in rclcpp_service_callback_added

Related links

https://tier4.atlassian.net/browse/RT2-1614

Notes for reviewers

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR has been properly tested.
  • The PR has been reviewed.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.05%. Comparing base (75e1c3f) to head (5bdcb3f).
Report is 18 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #289       +/-   ##
===========================================
+ Coverage   25.02%   55.05%   +30.03%     
===========================================
  Files          58       28       -30     
  Lines        3321     2185     -1136     
  Branches     1085     1212      +127     
===========================================
+ Hits          831     1203      +372     
+ Misses       1756      702     -1054     
+ Partials      734      280      -454     
Flag Coverage Δ
differential 55.05% <100.00%> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@miyakoshi-dev miyakoshi-dev requested a review from ymski June 11, 2024 04:13
@ymski
Copy link
Contributor

ymski commented Jun 12, 2024

LGTM

@miyakoshi-dev miyakoshi-dev merged commit 8fd2239 into tier4:main Jun 17, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants