Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change publish trace point definition #136

Merged
merged 2 commits into from
Aug 9, 2023

Conversation

ymski
Copy link
Contributor

@ymski ymski commented Jul 14, 2023

Description

Some parts of the current CARET define their own trace points. For future development, information that is no longer needed (e.g. message_timestamp in rclcpp_publish) will be removed and the function signatures will be modified to match.

Related links

Notes for reviewers

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR has been properly tested.
  • The PR has been reviewed.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yamasaki <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: +13.81 🎉

Comparison is base (8efaffe) 26.23% compared to head (4fd8ee1) 40.05%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #136       +/-   ##
===========================================
+ Coverage   26.23%   40.05%   +13.81%     
===========================================
  Files          58       28       -30     
  Lines        3106     1850     -1256     
  Branches      978      961       -17     
===========================================
- Hits          815      741       -74     
+ Misses       1574      396     -1178     
+ Partials      717      713        -4     
Flag Coverage Δ
differential 40.05% <0.00%> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
CARET_trace/src/ros_trace_points.cpp 41.51% <0.00%> (ø)

... and 30 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ymski ymski changed the title change publish tp feat: change publish trace point definition Jul 14, 2023
Signed-off-by: yamasaki <[email protected]>
@ymski ymski requested a review from isp-uetsuki July 14, 2023 06:14
@ymski ymski marked this pull request as ready for review July 31, 2023 06:05
Copy link
Contributor

@isp-uetsuki isp-uetsuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ymski ymski requested a review from nabetetsu August 2, 2023 03:06
Copy link
Collaborator

@nabetetsu nabetetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have confirmed that this fix works as expected in both the humble and iron environments; the iron environment needs an additional fix, but that is supposed to be done in a separate PR.

Here are the tracedata that is used for checking of humble and iron environment.
humble_evaluate.zip
Uploading iron_evaluate.zip…

@ymski ymski merged commit a169a40 into tier4:main Aug 9, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants