Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax highlighting in the README #254

Closed
etiennebacher opened this issue Aug 22, 2024 · 2 comments
Closed

Syntax highlighting in the README #254

etiennebacher opened this issue Aug 22, 2024 · 2 comments
Milestone

Comments

@etiennebacher
Copy link

Minor issue but the examples in the README can be hard to read without syntax highlighting and with all the links:

image

Examples of dplyr are much easier to read IMO:

image

I think this is just a matter of replacing output: downlit::readme_document by output: github_document in README.Rmd?

@krlmlr
Copy link
Member

krlmlr commented Aug 27, 2024

Thanks, interesting. I wasn't aware that downlit kills the syntax highlighting. Need to take a closer look.

joakimlinde added a commit to joakimlinde/duckplyr that referenced this issue Aug 28, 2024
Use github_document as output and update badges to match dplyr
@hadley hadley added this to the 1.0.0 milestone Sep 25, 2024
@krlmlr
Copy link
Member

krlmlr commented Sep 25, 2024

I think we're good here now, we only need to add the favicon.

@krlmlr krlmlr closed this as completed Sep 25, 2024
@krlmlr krlmlr mentioned this issue Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants