fix(ios): Fix Unsupported swift architecture #393
Conversation
AbdullahFaqeir
changed the title
|
@m1ga @hansemannn This was a good day for me, if e can approve the work flows for everything as I can't wait honestly |
|
@AbdullahFaqeir nice! Can you please add the .github/actions from https://github.com/tidev/hyperloop.next/pull/391/files so we can see that it is building online |
@m1ga done |
|
@AbdullahFaqeir I don't see the files in this PR. Can you check it again please |
fix(android): fix android actions
fix(android): fix android actions
fix(android): fix android actions
fix(android): fix android actions order
|
@m1ga |
|
no problem! We are almost there 😄 I can push some stuff later so minimize the changes. Happy that you help here to solve the iOS issue! |
|
When can we have it running, I'm really excited, I want to move to the next one hahaah |
|
@m1ga @hansemannn can someone send me the CLA And I'm proud I fixed it, proud that I'm giving back to you guys, proud of every hour I spent on each PR |
There was a problem hiding this comment.
LGTM. Both Android and iOS actions build now 👍 The CLA check is failing because the first commit was not done with the Github user.
@hansemannn please check it and then you can merge this and after that #391
Then we can create a new release to use it in the gradle 8 PR 👍
Fix when compiling module
Needed for #391
FINALY after around 7 hoursl