Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add-on not found when searching from within Thunderbird. #239

Open
dillenger opened this issue May 23, 2023 · 5 comments
Open

Add-on not found when searching from within Thunderbird. #239

dillenger opened this issue May 23, 2023 · 5 comments
Assignees

Comments

@dillenger
Copy link

When multiple versions of an add-on exist for multiple versions of Thunderbird the older version is not found when searching from within Thunderbird.

Header Tools Improved 3.9 works with Thunderbird 91.0 - 110.0
Header Tools Improved 4.0 works with Thunderbird 111.0 - 115.*

Searching from within Thunderbird 102.11.0 finds nothing:
https://addons.thunderbird.net/en-US/thunderbird/search/?q=Header%20Tools%20Improved&appver=102.11.0&platform=Linux

Searching from within Thunderbird 114.0b3 finds the add-on:
https://addons.thunderbird.net/en-US/thunderbird/search/?q=Header%20Tools%20Improved&appver=114.0&platform=Linux

The same thing happened with Compact Headers:
Version 3.5 works with Thunderbird 102.0 - 106.0, version 4.0b4 works with Thunderbird 107.0a1 - 110.0.

https://addons.thunderbird.net/en-US/thunderbird/search/?q=Compact%20Headers&appver=102.0&platform=Linux
didn't find anything with version 4.0b4 enabled on ATN, but when I disabled it searching from within Thunderbird 102 started working again.

Searching from within Thunderbird should always find the add-on.
IIRC this used to work correctly in the past.

@MyAddonsDev
Copy link

I also just discovered this problem, after I uploaded a new version of my add-on Mail Merge a few days ago:

The newest version 10.0.0 is compatible with Thunderbird 115.0a1 - 115.*.
The previous version 9.6.1 is compatible with Thunderbird 102.0a1 - 102.*.

Unfortunately a search on ATN for "Mail Merge" limited to "Thunderbird 102.0" does not find my add-on anymore:
https://addons.thunderbird.net/thunderbird/search/?q=mail%2Bmerge&appver=102.0&platform=all

@jobisoft
Copy link

The search is going wrong somewhere. Example: Edit Email Subject:
https://addons.thunderbird.net/de/thunderbird/addon/edit-email-subject/versions/

Version 7.2 : 115.0 - *
Version 6.2 : 102.0 - 115.*

It shows up in a general search:
https://addons.thunderbird.net/search/?q=edit+email

It does not show up in a search for a specific app version (which is what Thunderbird 102 does when searching for add-ons)
https://addons.thunderbird.net/search/?q=edit+email&appver=102.0

The result is wrong. It looks like the search is only searching in the subset of the most recent submissions.

@MelissaAutumn
Copy link
Member

I've confirmed ATN currently only looks at the current version when filtering by application version. I'll look into tweaking that, and hopefully have something by next week. Thanks for the report folks!

@MelissaAutumn MelissaAutumn self-assigned this Oct 6, 2023
@MelissaAutumn
Copy link
Member

Apologies for the delay. Due to the complexity discovered while investigating this issue we won't be implementing it in the near future.

Basically search only works with the latest addon version, thanks to a cached field on the addons table. Since there are multiple layers of version related tables, it would be too slow to simply do a lookup at the time of the search. Which means we have to add or modify a few database tables, adjust how two different search controllers work, ensure functionality is the same, ensure testing is up to date, etc... Its just too much work for now, but the functionality may show up in the future.

If you still need to support a 102 add-on, you may be able to upload it as a separate add-on.

@RealRaven2000
Copy link

Apologies for the delay. Due to the complexity discovered while investigating this issue we won't be implementing it in the near future.

If you still need to support a 102 add-on, you may be able to upload it as a separate add-on.

that's a pity, but understandable. as 115 and 102 are very different for us experimental Add-ons authors our strategy is to release backported patches for 102 first and then immediately follow up with a release for 115, because the newer platform has priority. Unfortunately it is also not possible to submit both at the same time, so we have to time our second upload very well to coincide with the review of the first one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants