Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

networkd: extend dhcp timeout on failure #2429

Open
maxux opened this issue Sep 24, 2024 · 2 comments
Open

networkd: extend dhcp timeout on failure #2429

maxux opened this issue Sep 24, 2024 · 2 comments
Labels
type_feature New feature or request
Milestone

Comments

@maxux
Copy link
Contributor

maxux commented Sep 24, 2024

The DHCP request always tries for 20 seconds and then timeouts.
https://github.com/threefoldtech/zos/blob/main/pkg/network/dhcp/dhcp.go#L50-L51

On networks that have switches with spanning-tree enabled or anything related, these ports can take several seconds before starting to forward and 20 seconds after the port is brought up can be too short.

Just extending this timeout would increase boot time for everybody, which is not the best idea either. I think a good compromise would be testing with a small timeout first then increase it if it fails.

@maxux maxux added the type_feature New feature or request label Sep 24, 2024
@ramezsaeed ramezsaeed added this to the 3.12 milestone Sep 29, 2024
@xmonader
Copy link
Collaborator

Can this wait till the next release? or is it a blocker?

@xmonader xmonader modified the milestones: 3.12, 3.11.3, 3.13 Sep 30, 2024
@maxux
Copy link
Contributor Author

maxux commented Oct 1, 2024

AFAIK this can wait, farmer affected fixed their switch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type_feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants