Adds zini restart subcommand #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashraf Fouda <[email protected]>
muhamadazmy
requested changes
Oct 16, 2023
src/app/mod.rs
Outdated
| let mut count = 0; | ||
| while count <= 20 { | ||
| let result = client.status(name).await?; | ||
| if result.state == "Success" && result.target == "Down" { |
There was a problem hiding this comment.
i think it's better to check the PID not the state, because the stat can still be Error or other when it's stopped bardo
src/app/mod.rs
Outdated
| client.start(name).await?; | ||
| return Ok(()); | ||
| } | ||
| time::sleep(std::time::Duration::from_secs(2)).await; |
There was a problem hiding this comment.
so we wait for 40 seconds? isn't this a bit too long?
I say we try every 1 second instead of 2
src/app/mod.rs
Outdated
| return Ok(()); | ||
| } | ||
| time::sleep(std::time::Duration::from_secs(2)).await; | ||
| count += 1; |
There was a problem hiding this comment.
when u switch to for u won't need this
Signed-off-by: Ashraf Fouda <[email protected]>
Signed-off-by: Ashraf Fouda <[email protected]>
Signed-off-by: Ashraf Fouda <[email protected]>
muhamadazmy
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.