Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KV store module in GO client #862

Closed
0oM4R opened this issue Sep 7, 2023 · 4 comments · Fixed by #1004
Closed

Add KV store module in GO client #862

0oM4R opened this issue Sep 7, 2023 · 4 comments · Fixed by #1004
Assignees
Milestone

Comments

@0oM4R
Copy link

0oM4R commented Sep 7, 2023

  • Add KV store valid function in go substrate
    this will be used in V client

this may help threefoldtecharchive/substrate-client@master...implement_kvstore

@sameh-farouk sameh-farouk added this to the later milestone Oct 31, 2023
@xmonader xmonader added this to 3.14.x Nov 5, 2023
@xmonader xmonader removed this from 3.13.x Nov 5, 2023
@renauter renauter modified the milestones: later, 2.8.0 Mar 21, 2024
@sameh-farouk
Copy link
Member

sameh-farouk commented Jun 2, 2024

Is this one still relevant @0oM4R @AhmedHanafy725
Do you mean tfchain-client-go ?

@sameh-farouk sameh-farouk modified the milestones: 2.8.0, 2.9.0 Jun 3, 2024
@sameh-farouk sameh-farouk removed this from 3.14.x Jun 3, 2024
@AhmedHanafy725
Copy link

not sure if it's still required for the v client, but it's good to have it on the tfchain go client

@Eslam-Nawara
Copy link
Contributor

Eslam-Nawara commented Sep 12, 2024

WIP:
After investigation, I was able to implement set/get and delete operations.

The listing of all key-value pairs had a problem that the client used in the chain doesn't support creating/listing using partial key, so couldn't list the keys in the store

Reported here:
centrifuge/go-substrate-rpc-client#300
centrifuge/go-substrate-rpc-client#365

we will need more time to find another client or fork and update the client to support using partial keys.

@Eslam-Nawara
Copy link
Contributor

Eslam-Nawara commented Sep 16, 2024

Work Completed

  • forked the rpc client and updated it to be able to use partial key to list all values in the store
  • updated the list function to return key-value pairs with decoded format

@github-project-automation github-project-automation bot moved this from Pending Review to Done in 3.15.x Sep 16, 2024
@sameh-farouk sameh-farouk moved this from Done to In Verification in 3.15.x Sep 17, 2024
@xmonader xmonader moved this from In Verification to Done in 3.15.x Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants