Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I am not able to output all my VM's Ygg addresses after the change of the argument ygg_ip to planetary_ip #919

Open
s-areal opened this issue May 7, 2024 · 5 comments
Milestone

Comments

@s-areal
Copy link

s-areal commented May 7, 2024

I have multiple VM running for months now.

I realized some random ygg ip addresses are lacking on terraform output:

ygg_ip_1410 = ""
ygg_ip_1413 = ""
ygg_ip_1458 = "302:f959:4b26:b3dc:f5bb:9fc3:7bef:b2fc"
ygg_ip_1554 = ""
ygg_ip_1591 = ""
ygg_ip_1598 = "300:1d67:64f1:941b:6b49:4c14:60e9:49ea"
ygg_ip_1609 = ""
ygg_ip_1675 = "301:8b73:6e74:709d:20b8:1940:ca8b:d218"

This never, ever happened before.

how can I output now, after ygg_ip changed to planetary_ip all the addresses of the VMs I am running?

I've tried changing the ygg_ip to planetary_ip on main.tf but i got this error message:

Error: Unsupported attribute

│ on main.tf line 2290, in output "Planetary_ip_1394":
│ 2290: value = grid_deployment._1394.vms[0].planetary_ip

│ This object has no argument, nested block, or exported attribute named "planetary_ip".

@s-areal s-areal changed the title I am not able to output all my VM's Ygg addresses after changing the argument ygg_ip to planetary_ip I am not able to output all my VM's Ygg addresses after the change of the argument ygg_ip to planetary_ip May 7, 2024
@scottyeager
Copy link

Also I think it's worth asking, why change ygg_ip to planetary_ip in the first place? If we continue with a notion of "planetary network", it would probably not involve Yggdrasil since we are now developing Mycelium as a replacement.

@xmonader
Copy link
Contributor

xmonader commented May 8, 2024

Also I think it's worth asking, why change ygg_ip to planetary_ip in the first place? If we continue with a notion of "planetary network", it would probably not involve Yggdrasil since we are now developing Mycelium as a replacement.

Mycelium is developed along with yggdrasil and the plan is still to support both

@ramezsaeed ramezsaeed added this to the 1.9.4 milestone May 8, 2024
@scottyeager
Copy link

Mycelium is developed along with yggdrasil and the plan is still to support both

I know we're not planning to drop support for Yggdrasil. I'm just saying that with Mycelium in play it no longer makes sense to give a special name to Yggdrasil in the context of the ThreeFold network. Calling it "Planetary Network" has always been a source of confusion anyway. Changing it here will only cause more confusion, and force people to update their main.tf files. So what's the upside?

@Mik-TF
Copy link

Mik-TF commented May 10, 2024

Mycelium is developed along with yggdrasil and the plan is still to support both

I agree it's important to keep the support of both.

The project mycelium states clearly in the book that it's the "planetary network":

image

So I guess to the minimum planetary should now be addressed for mycelium and yggdrasil should be yggdrasil and nothing more

  • planetary_ip for mycelium
  • yggdrasil_ip for yggdrasil

That being said, I do agree with Scott that

  • mycelium_ip
  • yggdrasil_ip

is the simplest and clearest.

IMO, if the nomenclature is already established in the community, docs and recent codes, we should revert to ygg_ip, and add myc_ip if needed for mycelium. This will be a smooth addition and not a change to properly working nomenclature, while being natural to users.

  • ygg_ip
  • myc_ip

Proposition

So I propose this, we don't use planetary as it's misleading. We go with this:

  • mycelium_ip and myc_ip
  • yggdrasil_ip and ygg_ip

@Mik-TF
Copy link

Mik-TF commented May 20, 2024

@xmonader does the following make sense to you?

  • mycelium_ip and myc_ip
  • yggdrasil_ip and ygg_ip

It'd be way easier to understand.

@ashraffouda ashraffouda modified the milestones: 1.10.1, 2.0.0 Jun 3, 2024
@rawdaGastan rawdaGastan modified the milestones: 2.0.0, later Sep 5, 2024
@rawdaGastan rawdaGastan modified the milestones: later, future Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants