Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rscan: wrong reply on simple dataset #146

Open
maxux opened this issue Dec 28, 2022 · 0 comments
Open

rscan: wrong reply on simple dataset #146

maxux opened this issue Dec 28, 2022 · 0 comments
Assignees
@maxux
Labels
type_bug

Comments

@maxux
Copy link
Collaborator

maxux commented Dec 28, 2022

In the latest branch, it seems that RSCAN is broken:

127.0.0.1:9900> rscan
1) "0\x00\x00\x00\x00\x00\x00\x00\x00\x03\x00\x00\x00\x00\x00\x00\x01"
2) 1) 1) ""
      2) (integer) 71
      3) (integer) 1960376187
   2) 1) ""
      2) (integer) -1408488960
      3) (integer) 155
   3) 1) "\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00*\x0c\xaccr\xe0\x8b\xa0\x00\x00\x00\x00\x9b\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\b\x1c\x00\x00\x00\x05\x00\x00\x00\x1d\x00\x00\x00\x01"
      2) (integer) 0
      3) (integer) 0

127.0.0.1:9900> scan
1) "\b\x00\x00\x00\x00\x10\x00\x00\x00\x1d\x00\x00\x00r\xe0\x8b\xa0"
2) 1) 1) "\x00\x00\x00\x00\x00\x00\x00\x00"
      2) (integer) 16
@maxux maxux added the type_bug label Dec 28, 2022
@maxux maxux self-assigned this Dec 28, 2022
maxux added a commit that referenced this issue Dec 28, 2022
@maxux
libzdb: attempt to fix RSCAN on sequenrial mode
946f6a3 
Issue #146 reports an issue using sequential mode and RSCAN not
returning sane values.

This is confirmed.

Code was still using old hardcoded fixed-length value (32 bits keys) not
relevant anymore, but moreover was still using a dirty fix needed
because of an old bug. This bug is probably not on the field anymore and
can be discarded, this commit bypass that old hotfix and use a more
classic/logic way how to deal RSCAN. Code will be cleaned after more
tests.
@maxux maxux mentioned this issue Dec 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxux maxux

Labels
type_bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@maxux