Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix template reference in modular-backbone example. #115

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from
Open

Fix template reference in modular-backbone example. #115

wants to merge 1 commit into from

Conversation

grze-s
Copy link

@grze-s grze-s commented Oct 13, 2014

Underscore templates no longer accept an initial data object. _.template
always returns a function now. Example didn't work with updated
underscore.js

Underscore templates no longer accept an initial data object. _.template
always returns a function now. Example didn't work with updated
underscore.js
@thomasdavis
Copy link
Owner

Awesome work. But did you change the version of underscore that the tutorial is using too?

@grze-s
Copy link
Author

grze-s commented Oct 14, 2014

I didn't include new underscore. The commit will work aither with old and new lilbrary. I've checked the project localy. Now it is working with all the newrest versions of underscore, backbone jQuery and require libraries. Backbone doesn't need to be downloaded from special fork now. Would you like me to include new versions of libraries in the commit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants