Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed storage get_url() token bug #417

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hereisamara
Copy link

The current get_url method takes the bearer token as a token URL parameter which in fact is a different token, named access token or download token.

I have changed the method so that it works for all types of firebase storage rules by retrieving the access token first and passing it into the URL.

Before the get_url() method returns
image

After changes, it returns the url with correct token
image

@AsifArmanRahman
Copy link

Hi there, I've initiated a project to maintain this library, and I'll be using your solution to fix the mentioned bug. I'll co-author you in the commit of the fix, as I've modified it a bit. Feel free to reach me using my email displayed in my profile.

Repo: firebase-rest-api available in PyPI

best regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants