Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Replace erc721 claim Drawer with Sheet #4932

Open
wants to merge 1 commit into
base: kien/reavel-nft-drawer
Choose a base branch
from

Conversation

kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Oct 6, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR refactors the NFTClaimButton component by replacing the Drawer UI with a Sheet component, enhancing the claim form's functionality and user experience for claiming NFTs.

Detailed summary

  • Removed the Drawer component and added a Sheet component for the claim UI.
  • Integrated react-hook-form for form handling.
  • Added input fields for "To Address" and "Amount" with validation.
  • Implemented transaction handling with TransactionButton.
  • Enhanced error handling and user feedback with toast.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Oct 6, 2024

⚠️ No Changeset found

Latest commit: 24f3496

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

graphite-app bot commented Oct 6, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

vercel bot commented Oct 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2024 0:33am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 6, 2024 0:33am
thirdweb_playground ⬜️ Skipped (Inspect) Oct 6, 2024 0:33am
wallet-ui ⬜️ Skipped (Inspect) Oct 6, 2024 0:33am

@vercel vercel bot temporarily deployed to Preview – docs-v2 October 6, 2024 04:42 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 6, 2024 04:42 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 6, 2024 04:42 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 6, 2024
Copy link
Contributor Author

kien-ngo commented Oct 6, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @kien-ngo and the rest of your teammates on Graphite Graphite

Copy link

codecov bot commented Oct 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.61%. Comparing base (bd08762) to head (24f3496).

Additional details and impacted files
@@                   Coverage Diff                   @@
##           kien/reavel-nft-drawer    #4932   +/-   ##
=======================================================
  Coverage                   47.61%   47.61%           
=======================================================
  Files                        1057     1057           
  Lines                       57241    57241           
  Branches                     3925     3925           
=======================================================
  Hits                        27256    27256           
  Misses                      29296    29296           
  Partials                      689      689           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 11de1f3
packages 43.37% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

github-actions bot commented Oct 6, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.1 KB (0%) 842 ms (0%) 2.4 s (+23.23% 🔺) 3.3 s
thirdweb (cjs) 101.73 KB (0%) 2.1 s (0%) 4.5 s (-9.72% 🔽) 6.5 s
thirdweb (minimal + tree-shaking) 4.82 KB (0%) 97 ms (0%) 228 ms (+27.44% 🔺) 325 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 125 ms (+190.52% 🔺) 135 ms
thirdweb/react (minimal + tree-shaking) 17.23 KB (0%) 345 ms (0%) 323 ms (-44.78% 🔽) 667 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant