Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Fix minor layer issues #4928

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Oct 5, 2024

Before:
image

After:
image


PR-Codex overview

This PR focuses on updating the layout of certain components in the NFT dashboard to improve responsiveness and visual structure by changing flex direction and adjusting spacing.

Detailed summary

  • In supply-cards.tsx, changed the flex direction from flex-row to flex-col for the outer div.
  • In page.tsx, modified the outer div from flex-row to flex-col while adding gap-3 for better spacing on smaller screens.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Oct 5, 2024

⚠️ No Changeset found

Latest commit: 5493655

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2024 1:16am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 5, 2024 1:16am
thirdweb_playground ⬜️ Skipped (Inspect) Oct 5, 2024 1:16am
wallet-ui ⬜️ Skipped (Inspect) Oct 5, 2024 1:16am

Copy link

graphite-app bot commented Oct 5, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 5, 2024
Copy link

codecov bot commented Oct 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.61%. Comparing base (4660e0c) to head (5493655).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4928   +/-   ##
=======================================
  Coverage   47.61%   47.61%           
=======================================
  Files        1057     1057           
  Lines       57241    57241           
  Branches     3926     3926           
=======================================
  Hits        27256    27256           
  Misses      29296    29296           
  Partials      689      689           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 4660e0c
packages 43.37% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

github-actions bot commented Oct 5, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.1 KB (0%) 842 ms (0%) 2.3 s (-19.74% 🔽) 3.1 s
thirdweb (cjs) 101.73 KB (0%) 2.1 s (0%) 3.9 s (-3.09% 🔽) 6 s
thirdweb (minimal + tree-shaking) 4.82 KB (0%) 97 ms (0%) 307 ms (+201.41% 🔺) 404 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 87 ms (+201.36% 🔺) 97 ms
thirdweb/react (minimal + tree-shaking) 17.23 KB (0%) 345 ms (0%) 574 ms (+57.1% 🔺) 918 ms

@kien-ngo kien-ngo changed the title [Dashboard] Fix nimor layer issues [Dashboard] Fix minor layer issues Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant