Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Engine Overview page to shadcn/tailwind - Part1 #4926

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Oct 4, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on refactoring the CreateBackendWalletButton and ImportBackendWalletButton components to use a new dialog system, enhancing the user interface and improving code structure. It also introduces tooltips and updates form handling for better user experience.

Detailed summary

  • Replaced Modal with Dialog for CreateBackendWalletButton and ImportBackendWalletButton.
  • Added tooltip prop in FormFieldSetup.
  • Updated form handling for better state management and error display.
  • Enhanced UI elements with improved styling and layout.
  • Refactored wallet import and creation logic for clarity and maintainability.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Oct 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 7:39pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 4, 2024 7:39pm
thirdweb_playground ⬜️ Skipped (Inspect) Oct 4, 2024 7:39pm
wallet-ui ⬜️ Skipped (Inspect) Oct 4, 2024 7:39pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui October 4, 2024 19:13 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 4, 2024 19:13 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 4, 2024 19:13 Inactive
Copy link

changeset-bot bot commented Oct 4, 2024

⚠️ No Changeset found

Latest commit: 8a74e08

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

graphite-app bot commented Oct 4, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 4, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

@MananTank MananTank marked this pull request as ready for review October 4, 2024 19:14
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.61%. Comparing base (b148fa0) to head (8a74e08).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4926   +/-   ##
=======================================
  Coverage   47.61%   47.61%           
=======================================
  Files        1057     1057           
  Lines       57224    57224           
  Branches     3924     3924           
=======================================
  Hits        27247    27247           
  Misses      29288    29288           
  Partials      689      689           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from b148fa0
packages 43.37% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

github-actions bot commented Oct 4, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 41.96 KB (0%) 840 ms (0%) 2.9 s (-16.17% 🔽) 3.7 s
thirdweb (cjs) 101.68 KB (0%) 2.1 s (0%) 7.9 s (+32.31% 🔺) 9.9 s
thirdweb (minimal + tree-shaking) 4.82 KB (0%) 97 ms (0%) 200 ms (-45.33% 🔽) 297 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 130 ms (-13.93% 🔽) 140 ms
thirdweb/react (minimal + tree-shaking) 17.23 KB (0%) 345 ms (0%) 621 ms (-29.51% 🔽) 965 ms

@MananTank MananTank force-pushed the 10-05-migrate_engine_overview_page_to_shadcn_tailwind_-_part1 branch from 1eec780 to cd7b668 Compare October 4, 2024 19:19
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 4, 2024 19:19 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 4, 2024 19:19 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 4, 2024 19:19 Inactive
@MananTank MananTank force-pushed the 10-05-migrate_engine_overview_page_to_shadcn_tailwind_-_part1 branch from cd7b668 to 8a74e08 Compare October 4, 2024 19:26
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 4, 2024 19:26 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 4, 2024 19:26 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 4, 2024 19:26 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant