-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dashboard] Remove <Code /> component (ez mode) #4787
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
size-limit report 📦
|
37a05d3
to
2884702
Compare
730ea1f
to
48eed45
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4787 +/- ##
=======================================
Coverage 47.59% 47.59%
=======================================
Files 1054 1054
Lines 57136 57136
Branches 3914 3914
=======================================
Hits 27195 27195
Misses 29253 29253
Partials 688 688
*This pull request uses carry forward flags. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think unstyled code element looks similar to Chakra Code component. Can you verify? Most likely we'll need to add background, a bit of padding, rounded corners etc
We can make a |
apps/dashboard/src/contract-ui/tabs/claim-conditions/components/snapshot-upload.tsx
Outdated
Show resolved
Hide resolved
bfc9db6
to
850e9f4
Compare
Merge activity
|
## Problem solved Short description of the bug fixed or feature added <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on enhancing code readability by replacing instances of the `Code` component from Chakra UI with a new `InlineCode` component, which provides a consistent styling for inline code snippets across various files. ### Detailed summary - Added `InlineCode` component in `inline-code.tsx`. - Replaced `Code` with `InlineCode` in multiple components for improved consistency: - `ChainValidation` - `EngineCorsConfig` - `EngineIpAllowlistConfig` - `InteractiveAbiFunction` - `EngineAccessTokens` - `SnapshotUpload` - `UploadStep` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
850e9f4
to
a2ce5f5
Compare
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on enhancing the user interface by replacing instances of
<Code>
components with a new<InlineCode>
component for better styling and consistency across the application.Detailed summary
InlineCode
component toinline-code.tsx
.<Code>
with<InlineCode>
in various components for:ChainValidation
EngineCorsConfig
EngineIpAllowlistConfig
InteractiveAbiFunction
EngineAccessTokens
SnapshotUpload
UploadStep