Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Remove <Code /> component (ez mode) #4787

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Sep 24, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on enhancing the user interface by replacing instances of <Code> components with a new <InlineCode> component for better styling and consistency across the application.

Detailed summary

  • Added InlineCode component to inline-code.tsx.
  • Replaced <Code> with <InlineCode> in various components for:
    • ChainValidation
    • EngineCorsConfig
    • EngineIpAllowlistConfig
    • InteractiveAbiFunction
    • EngineAccessTokens
    • SnapshotUpload
    • UploadStep

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Sep 24, 2024

⚠️ No Changeset found

Latest commit: a2ce5f5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Sep 24, 2024
@kien-ngo kien-ngo changed the title Remove <Code /> component` [Dashboard] Remove <Code /> component (ez mode) Sep 24, 2024
@vercel vercel bot temporarily deployed to Preview – wallet-ui September 24, 2024 15:02 Inactive
Copy link

vercel bot commented Sep 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 9:06pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 1, 2024 9:06pm
thirdweb_playground ⬜️ Skipped (Inspect) Oct 1, 2024 9:06pm
wallet-ui ⬜️ Skipped (Inspect) Oct 1, 2024 9:06pm

@kien-ngo kien-ngo marked this pull request as ready for review September 24, 2024 15:02
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground September 24, 2024 15:02 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 September 24, 2024 15:02 Inactive
Copy link

graphite-app bot commented Sep 24, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor

github-actions bot commented Sep 24, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 41.91 KB (0%) 839 ms (0%) 1.3 s (-4.75% 🔽) 2.2 s
thirdweb (cjs) 101.54 KB (0%) 2.1 s (0%) 2.2 s (+4.09% 🔺) 4.3 s
thirdweb (minimal + tree-shaking) 4.82 KB (0%) 97 ms (0%) 221 ms (+58.7% 🔺) 318 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 39 ms (-42.16% 🔽) 49 ms
thirdweb/react (minimal + tree-shaking) 16.76 KB (0%) 336 ms (0%) 281 ms (+64.48% 🔺) 616 ms

@vercel vercel bot temporarily deployed to Preview – wallet-ui September 24, 2024 15:08 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground September 24, 2024 15:08 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 September 24, 2024 15:08 Inactive
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.59%. Comparing base (6beec7a) to head (a2ce5f5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4787   +/-   ##
=======================================
  Coverage   47.59%   47.59%           
=======================================
  Files        1054     1054           
  Lines       57136    57136           
  Branches     3914     3914           
=======================================
  Hits        27195    27195           
  Misses      29253    29253           
  Partials      688      688           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 6beec7a
packages 43.34% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Member

@MananTank MananTank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think unstyled code element looks similar to Chakra Code component. Can you verify? Most likely we'll need to add background, a bit of padding, rounded corners etc

Copy link
Member

We can make a InlineCode component and use it everywhere

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 1, 2024 20:11 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 1, 2024 20:11 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 1, 2024 20:27 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 1, 2024 20:27 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 1, 2024 20:27 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 1, 2024 20:28 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 1, 2024 20:28 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 1, 2024 20:28 Inactive
Copy link

graphite-app bot commented Oct 1, 2024

Merge activity

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on enhancing code readability by replacing instances of the `Code` component from Chakra UI with a new `InlineCode` component, which provides a consistent styling for inline code snippets across various files.

### Detailed summary
- Added `InlineCode` component in `inline-code.tsx`.
- Replaced `Code` with `InlineCode` in multiple components for improved consistency:
  - `ChainValidation`
  - `EngineCorsConfig`
  - `EngineIpAllowlistConfig`
  - `InteractiveAbiFunction`
  - `EngineAccessTokens`
  - `SnapshotUpload`
  - `UploadStep`

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 1, 2024 21:04 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 1, 2024 21:04 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 1, 2024 21:04 Inactive
@graphite-app graphite-app bot merged commit a2ce5f5 into main Oct 1, 2024
30 checks passed
@graphite-app graphite-app bot deleted the kien/remove-Code-ez-mode branch October 1, 2024 21:07
@vercel vercel bot temporarily deployed to Production – wallet-ui October 1, 2024 21:07 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 1, 2024 21:07 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 October 1, 2024 21:07 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants