[Dashboard] Remove Flex easy mode #4785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This was referenced Sep 24, 2024
kien-ngo
requested review from
jnsdls,
MananTank and
joaquim-verges
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4785 +/- ##
=======================================
Coverage 49.13% 49.13%
=======================================
Files 1051 1051
Lines 56681 56681
Branches 3889 3889
=======================================
Hits 27850 27850
Misses 28198 28198
Partials 633 633
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
kien-ngo
force-pushed
the
kien/remove-more-flex
branch
from
3eba1e6
to
c5198d1
Compare
kien-ngo
force-pushed
the
kien/remove-more-flex-2
branch
from
6a12e75
to
d64fdba
Compare
kien-ngo
force-pushed
the
kien/remove-more-flex
branch
from
c5198d1
to
5b7f091
Compare
kien-ngo
force-pushed
the
kien/remove-more-flex
branch
from
2c5187c
to
a22bb73
Compare
kien-ngo
force-pushed
the
kien/remove-more-flex-2
branch
from
62c6839
to
2275b64
Compare
Merge activity
|
kien-ngo
force-pushed
the
kien/remove-more-flex
branch
from
a22bb73
to
65eda76
Compare
kien-ngo
added a commit
that referenced
this pull request
Sep 25, 2024
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on replacing instances of the `Flex` component with `div` elements styled with `flex` classes, streamlining the layout structure across various components in the project.
### Detailed summary
- Replaced `<Flex>` with `<div className="flex flex-row">` in multiple files.
- Updated layout in `snapshot-upload.tsx`, `airdrop-upload.tsx`, `batch-lazy-mint.tsx`, and others.
- Ensured consistent flexbox styling across components without altering functionality.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
kien-ngo
force-pushed
the
kien/remove-more-flex-2
branch
from
2275b64
to
0a021c6
Compare
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on replacing instances of the `Flex` component with `div` elements that have corresponding CSS classes for layout styling. This change aims to streamline the code while maintaining the same visual structure.
### Detailed summary
- Replaced `<Flex>` with `<div className="flex flex-row">` in multiple components for horizontal alignment.
- Replaced `<Flex>` with `<div className="flex flex-col">` in several components for vertical alignment.
- Ensured all functional components maintain the same layout and behavior after changes.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
jnsdls
force-pushed
the
kien/remove-more-flex
branch
from
65eda76
to
46acf33
Compare
jnsdls
force-pushed
the
kien/remove-more-flex-2
branch
from
0a021c6
to
d76618f
Compare
vercel
bot
temporarily deployed
to
Production – thirdweb_playground
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on replacing instances of the
Flexcomponent withdivelements styled withflexclasses across various files in the codebase. This change aims to standardize the layout structure while maintaining the same visual appearance.Detailed summary
<Flex>with<div className="flex flex-row">in multiple components for consistency.<Flex direction="column">to<div className="flex flex-col">in various files.