Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Network Config Modal from chakra to shadcn/tailwind #4745

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Sep 21, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR removes deprecated components, updates UI elements, and refactors form fields in the dashboard.

Detailed summary

  • Removed deprecated components: TooltipBox.tsx, ConfirmationPopover.tsx, thirdweb.client.ts
  • Updated UI elements in various components
  • Refactored form fields in ChainIdInput.tsx, RpcInput.tsx, NetworkIdInput.tsx, and FormFieldSetup.tsx

The following files were skipped due to too many changes: apps/dashboard/src/@/components/ui/radio-group.tsx, apps/dashboard/src/components/configure-networks/ConfigureNetworkForm.tsx

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Sep 21, 2024

⚠️ No Changeset found

Latest commit: bc72883

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Sep 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 21, 2024 9:28pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Sep 21, 2024 9:28pm
thirdweb_playground ⬜️ Skipped (Inspect) Sep 21, 2024 9:28pm
wallet-ui ⬜️ Skipped (Inspect) Sep 21, 2024 9:28pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui September 21, 2024 20:31 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 September 21, 2024 20:31 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground September 21, 2024 20:31 Inactive
Copy link

graphite-app bot commented Sep 21, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@MananTank MananTank marked this pull request as ready for review September 21, 2024 20:31
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Sep 21, 2024
Copy link
Member Author

MananTank commented Sep 21, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

Copy link

codecov bot commented Sep 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.92%. Comparing base (0a4e445) to head (bc72883).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4745   +/-   ##
=======================================
  Coverage   48.92%   48.92%           
=======================================
  Files        1050     1050           
  Lines       57002    57002           
  Branches     3892     3892           
=======================================
  Hits        27889    27889           
  Misses      28480    28480           
  Partials      633      633           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 0a4e445
packages 44.97% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

github-actions bot commented Sep 21, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43.67 KB (0%) 874 ms (0%) 3.4 s (+4.81% 🔺) 4.3 s
thirdweb (cjs) 101.2 KB (0%) 2.1 s (0%) 7.1 s (+23.3% 🔺) 9.1 s
thirdweb (minimal + tree-shaking) 4.85 KB (0%) 98 ms (0%) 551 ms (+46.62% 🔺) 648 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 165 ms (+103.87% 🔺) 175 ms
thirdweb/react (minimal + tree-shaking) 16.72 KB (0%) 335 ms (0%) 788 ms (+4.66% 🔺) 1.2 s

@MananTank MananTank force-pushed the 09-22-migrate_network_config_modal_from_chakra_to_shadcn_tailwind branch from ec520ca to 53a9505 Compare September 21, 2024 20:46
@vercel vercel bot temporarily deployed to Preview – docs-v2 September 21, 2024 20:46 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground September 21, 2024 20:46 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui September 21, 2024 20:46 Inactive
@MananTank MananTank force-pushed the 09-21-remove_all_chain_override_contexts_and_move_to_global_store branch from 2e04236 to 2c8d52d Compare September 21, 2024 20:48
@MananTank MananTank force-pushed the 09-22-migrate_network_config_modal_from_chakra_to_shadcn_tailwind branch from 53a9505 to c4e7e01 Compare September 21, 2024 20:49
@vercel vercel bot temporarily deployed to Preview – docs-v2 September 21, 2024 20:49 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground September 21, 2024 20:49 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui September 21, 2024 20:49 Inactive
@MananTank MananTank force-pushed the 09-22-migrate_network_config_modal_from_chakra_to_shadcn_tailwind branch from c4e7e01 to c042a12 Compare September 21, 2024 21:04
@vercel vercel bot temporarily deployed to Preview – wallet-ui September 21, 2024 21:04 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 September 21, 2024 21:04 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground September 21, 2024 21:04 Inactive
@MananTank MananTank changed the base branch from 09-21-remove_all_chain_override_contexts_and_move_to_global_store to graphite-base/4745 September 21, 2024 21:10
Copy link

graphite-app bot commented Sep 21, 2024

Merge activity

@MananTank MananTank changed the base branch from graphite-base/4745 to main September 21, 2024 21:15
@MananTank MananTank force-pushed the 09-22-migrate_network_config_modal_from_chakra_to_shadcn_tailwind branch from c042a12 to 2856ffc Compare September 21, 2024 21:19
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground September 21, 2024 21:19 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui September 21, 2024 21:19 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 September 21, 2024 21:19 Inactive
## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR removes unused components, updates UI elements, and refactors form fields in the dashboard application.

### Detailed summary
- Deleted `TooltipBox.tsx` and `ConfirmationPopover.tsx`
- Updated UI elements in `IconUpload.tsx` and `ConfigureNetworkModal.tsx`
- Refactored form fields in `ChainIdInput.tsx`, `RpcInput.tsx`, and `NetworkIDInput.tsx`

> The following files were skipped due to too many changes: `apps/dashboard/src/@/components/ui/radio-group.tsx`, `apps/dashboard/src/components/configure-networks/ConfigureNetworkForm.tsx`

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the 09-22-migrate_network_config_modal_from_chakra_to_shadcn_tailwind branch from 2856ffc to bc72883 Compare September 21, 2024 21:24
@vercel vercel bot temporarily deployed to Preview – wallet-ui September 21, 2024 21:24 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground September 21, 2024 21:24 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 September 21, 2024 21:24 Inactive
@graphite-app graphite-app bot merged commit bc72883 into main Sep 21, 2024
30 checks passed
@graphite-app graphite-app bot deleted the 09-22-migrate_network_config_modal_from_chakra_to_shadcn_tailwind branch September 21, 2024 21:28
@vercel vercel bot temporarily deployed to Production – thirdweb_playground September 21, 2024 21:28 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 September 21, 2024 21:28 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui September 21, 2024 21:28 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants