Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: show min version number #4744

Merged
merged 1 commit into from
Sep 21, 2024
Merged

chore: show min version number #4744

merged 1 commit into from
Sep 21, 2024

Conversation

arcoraven
Copy link
Contributor

@arcoraven arcoraven commented Sep 21, 2024

PR-Codex overview

This PR enhances the alert management feature in ManageEngineAlerts.tsx for cloud-hosted Engines by specifying the required version.

Detailed summary

  • Updated the label text to specify that the feature is available for cloud-hosted Engines running v2.0.10 or later.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Sep 21, 2024

⚠️ No Changeset found

Latest commit: f2307fd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Sep 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 21, 2024 4:33pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Sep 21, 2024 4:33pm
thirdweb_playground ⬜️ Skipped (Inspect) Sep 21, 2024 4:33pm
wallet-ui ⬜️ Skipped (Inspect) Sep 21, 2024 4:33pm

Copy link

graphite-app bot commented Sep 21, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Sep 21, 2024
@arcoraven arcoraven added the merge-queue Adds the pull request to Graphite's merge queue. label Sep 21, 2024
Copy link

graphite-app bot commented Sep 21, 2024

Merge activity

  • Sep 21, 12:25 PM EDT: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 21, 12:29 PM EDT: arcoraven added this pull request to the Graphite merge queue.
  • Sep 21, 12:34 PM EDT: arcoraven merged this pull request with the Graphite merge queue.

Copy link

codecov bot commented Sep 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.92%. Comparing base (a4dac95) to head (f2307fd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4744   +/-   ##
=======================================
  Coverage   48.92%   48.92%           
=======================================
  Files        1050     1050           
  Lines       57002    57002           
  Branches     3892     3892           
=======================================
  Hits        27889    27889           
  Misses      28480    28480           
  Partials      633      633           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from a4dac95
packages 44.97% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

github-actions bot commented Sep 21, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43.67 KB (0%) 874 ms (0%) 663 ms (+53% 🔺) 1.6 s
thirdweb (cjs) 101.2 KB (0%) 2.1 s (0%) 984 ms (-1.11% 🔽) 3.1 s
thirdweb (minimal + tree-shaking) 4.85 KB (0%) 98 ms (0%) 146 ms (+304.92% 🔺) 243 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 85 ms (+377.86% 🔺) 95 ms
thirdweb/react (minimal + tree-shaking) 16.72 KB (0%) 335 ms (0%) 227 ms (+193.44% 🔺) 562 ms

<!-- start pr-codex -->

## PR-Codex overview
This PR updates the alert management feature message for cloud-hosted Engines to specify version requirement.

### Detailed summary
- Updated alert management feature message for cloud-hosted Engines to require v2.0.10 or later.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@vercel vercel bot temporarily deployed to Preview – wallet-ui September 21, 2024 16:30 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 September 21, 2024 16:30 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground September 21, 2024 16:30 Inactive
@graphite-app graphite-app bot merged commit f2307fd into main Sep 21, 2024
30 checks passed
@graphite-app graphite-app bot deleted the ph/engineVersionAlerts branch September 21, 2024 16:34
@vercel vercel bot temporarily deployed to Production – docs-v2 September 21, 2024 16:34 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui September 21, 2024 16:34 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground September 21, 2024 16:34 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard. merge-queue Adds the pull request to Graphite's merge queue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants