Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pregenerate docs #4736

Merged
merged 1 commit into from
Sep 21, 2024
Merged

Update pregenerate docs #4736

merged 1 commit into from
Sep 21, 2024

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Sep 21, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

The focus of this PR is to enhance the pregeneration of wallet addresses by allowing different strategies like email, phone, or custom user id.

Detailed summary

  • Updated request body parameters to include phone and userId
  • Added sections for email, phone, and custom user id based wallets with examples
  • Clarified the headers and example curl command sections
  • Renamed and restructured sections for better clarity

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Signed-off-by: Joaquim Verges <[email protected]>
Copy link

changeset-bot bot commented Sep 21, 2024

⚠️ No Changeset found

Latest commit: 7592f48

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Sep 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 🔄 Building (Inspect) Visit Preview 💬 Add feedback Sep 21, 2024 1:09am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
thirdweb_playground ⬜️ Skipped (Inspect) Sep 21, 2024 1:09am
thirdweb-www ⬜️ Skipped (Inspect) Sep 21, 2024 1:09am
wallet-ui ⬜️ Skipped (Inspect) Sep 21, 2024 1:09am

Copy link

graphite-app bot commented Sep 21, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Sep 21, 2024
Copy link

codecov bot commented Sep 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.21%. Comparing base (6e3669d) to head (7592f48).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4736      +/-   ##
==========================================
- Coverage   50.61%   49.21%   -1.40%     
==========================================
  Files        1024     1046      +22     
  Lines       54578    56556    +1978     
  Branches     3888     3892       +4     
==========================================
+ Hits        27624    27836     +212     
- Misses      26321    28087    +1766     
  Partials      633      633              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 6e3669d
packages 45.29% <ø> (-1.57%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 28 files with indirect coverage changes

Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43.67 KB (0%) 874 ms (0%) 1.5 s (+175.86% 🔺) 2.4 s
thirdweb (cjs) 101.2 KB (0%) 2.1 s (0%) 1.9 s (+18.9% 🔺) 4 s
thirdweb (minimal + tree-shaking) 4.85 KB (0%) 98 ms (0%) 167 ms (+50.83% 🔺) 264 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 355 ms (+1349.02% 🔺) 365 ms
thirdweb/react (minimal + tree-shaking) 16.72 KB (0%) 335 ms (0%) 239 ms (+1.87% 🔺) 574 ms

@joaquim-verges joaquim-verges merged commit 997bfa8 into main Sep 21, 2024
29 of 30 checks passed
@joaquim-verges joaquim-verges deleted the joaquim-verges-patch-1 branch September 21, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Portal Involves changes to the Portal (docs) codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant