Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix body height issue in dashboard #4724

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Sep 20, 2024

Fixes body not expanding to content size:

image.png


PR-Codex overview

The focus of this PR is to update the global CSS to set a minimum height of 100% for the body element. Additionally, the layout component for team pages now uses min-h-screen instead of min-h-full.

Detailed summary

  • Set min-height: 100% for the body element in global CSS.
  • Changed min-h-full to min-h-screen in the team layout component.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Sep 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 2:18pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Sep 20, 2024 2:18pm
thirdweb_playground ⬜️ Skipped (Inspect) Sep 20, 2024 2:18pm
wallet-ui ⬜️ Skipped (Inspect) Sep 20, 2024 2:18pm

Copy link

changeset-bot bot commented Sep 20, 2024

⚠️ No Changeset found

Latest commit: fb92f87

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – wallet-ui September 20, 2024 11:57 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground September 20, 2024 11:57 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 September 20, 2024 11:57 Inactive
Copy link

graphite-app bot commented Sep 20, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Sep 20, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

@MananTank MananTank marked this pull request as ready for review September 20, 2024 11:57
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.61%. Comparing base (63ada20) to head (fb92f87).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4724   +/-   ##
=======================================
  Coverage   50.61%   50.61%           
=======================================
  Files        1024     1024           
  Lines       54578    54578           
  Branches     3891     3891           
=======================================
  Hits        27622    27622           
  Misses      26323    26323           
  Partials      633      633           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 63ada20
packages 46.85% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@MananTank MananTank changed the title Fix layout height issues in dashboard Fix body height issue in dashboard Sep 20, 2024
Copy link
Contributor

github-actions bot commented Sep 20, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43.67 KB (0%) 874 ms (0%) 508 ms (+78.55% 🔺) 1.4 s
thirdweb (cjs) 101.2 KB (0%) 2.1 s (0%) 805 ms (+15.51% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 4.85 KB (0%) 98 ms (0%) 84 ms (+248.84% 🔺) 181 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 40 ms (+501.42% 🔺) 50 ms
thirdweb/react (minimal + tree-shaking) 16.72 KB (0%) 335 ms (0%) 177 ms (+99.58% 🔺) 511 ms

Copy link

graphite-app bot commented Sep 20, 2024

Merge activity

@MananTank MananTank force-pushed the 09-20-fix_layout_height_issues_in_dashboard branch from df712d1 to fb92f87 Compare September 20, 2024 14:15
@vercel vercel bot temporarily deployed to Preview – docs-v2 September 20, 2024 14:15 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui September 20, 2024 14:15 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground September 20, 2024 14:15 Inactive
@graphite-app graphite-app bot merged commit fb92f87 into main Sep 20, 2024
30 checks passed
@graphite-app graphite-app bot deleted the 09-20-fix_layout_height_issues_in_dashboard branch September 20, 2024 14:19
@vercel vercel bot temporarily deployed to Production – wallet-ui September 20, 2024 14:19 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground September 20, 2024 14:19 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 September 20, 2024 14:19 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants