fix: show user info for ecosystem wallets #4715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 7d547a4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
joaquim-verges
requested review from
gregfromstl,
MananTank,
jnsdls and
edwardysun
as code owners
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @joaquim-verges and the rest of your teammates on |
size-limit report 📦
|
gregfromstl
reviewed
Sep 19, 2024
joaquim-verges
force-pushed
the
fix_show_user_info_for_ecosystem_wallets
branch
from
e55ed12
to
2c04dd3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4715 +/- ##
==========================================
- Coverage 50.62% 50.61% -0.02%
==========================================
Files 1024 1024
Lines 54559 54578 +19
Branches 3891 3891
==========================================
- Hits 27623 27622 -1
- Misses 26303 26323 +20
Partials 633 633
*This pull request uses carry forward flags. Click here to find out more.
|
Merge activity
|
gregfromstl
approved these changes
Sep 20, 2024
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on fixing the display of user information for ecosystem wallets in the Thirdweb application.
### Detailed summary
- Updated function name from `getEnclaveUserStatus` to `getUserStatus` in multiple files.
- Modified parameters in functions to include `ecosystem` for ecosystem wallets.
- Updated caching mechanism for InAppWalletConnector.
- Added logic to handle ecosystem wallets in `InAppWalletUserInfo` component.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
joaquim-verges
force-pushed
the
fix_show_user_info_for_ecosystem_wallets
branch
from
09e2739
to
7d547a4
Compare
graphite-app
bot
deleted the
fix_show_user_info_for_ecosystem_wallets
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on fixing the display of user information for ecosystem wallets in the Thirdweb application.
Detailed summary
getEnclaveUserStatustogetUserStatusfor consistency.ecosystemparameter for ecosystem wallets.isEcosystemWalletfor ecosystem wallet identification.InAppWalletUserInfocomponent to handle ecosystem wallet information retrieval.