-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New zksolc metadata format #4568
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 3f83a37 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4568 +/- ##
=======================================
Coverage 49.13% 49.14%
=======================================
Files 1051 1051
Lines 56681 56711 +30
Branches 3889 3889
=======================================
+ Hits 27850 27869 +19
- Misses 28198 28209 +11
Partials 633 633
*This pull request uses carry forward flags. Click here to find out more.
|
Merge activity
|
## Problem solved Handle new zksolc metadata format ref: ipfs://QmS6ehXYWKJEJq3LBSfG2ujKPzQQJooNE7L375zyFbpxmw <!-- start pr-codex --> --- ## PR-Codex overview This PR introduces support for a new `zksolc` metadata format in the `thirdweb` package, enhancing the handling of zkSync contracts by updating various functions and types to accommodate the new compiler type. ### Detailed summary - Added `compilerType` option to several functions and types to support `solc` and `zksolc`. - Updated `fetchPublishedContractMetadata` and `deployPublishedContract` to utilize `compilerType`. - Enhanced `formatCompilerMetadata` to handle `zksolc` specific metadata. - Modified `fetchDeployMetadata` to validate and fetch `zksolc` metadata correctly. - Updated `CustomContractForm` to determine `compilerType` based on the active wallet chain. - Improved error handling for missing `zksolc` metadata. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
010b502
to
3f83a37
Compare
Problem solved
Handle new zksolc metadata format
ref: ipfs://QmS6ehXYWKJEJq3LBSfG2ujKPzQQJooNE7L375zyFbpxmw
PR-Codex overview
This PR introduces support for a new
zksolc
compiler type, enhancing the handling of zkSync metadata and related functionalities across various components in thethirdweb
package.Detailed summary
compilerType
option to multiple functions and types.zksolc
metadata format infetchDeployMetadata
.formatCompilerMetadata
to processzksolc
metadata.zksolc
.