Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wallet UI] Fix: remove default favicon #4494

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

gregfromstl
Copy link
Member

@gregfromstl gregfromstl commented Sep 9, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR removes the favicon.ico file from the wallet-ui app.

Detailed summary

  • Deleted favicon.ico file from wallet-ui app

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Sep 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 10, 2024 2:00am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Sep 10, 2024 2:00am
thirdweb_playground ⬜️ Skipped (Inspect) Sep 10, 2024 2:00am
thirdweb-www ⬜️ Skipped (Inspect) Sep 10, 2024 2:00am

Copy link

changeset-bot bot commented Sep 9, 2024

⚠️ No Changeset found

Latest commit: eb88ed6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

graphite-app bot commented Sep 9, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.77%. Comparing base (8119db0) to head (eb88ed6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4494   +/-   ##
=======================================
  Coverage   47.77%   47.77%           
=======================================
  Files        1014     1014           
  Lines       53287    53287           
  Branches     3705     3705           
=======================================
  Hits        25460    25460           
  Misses      27143    27143           
  Partials      684      684           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 8119db0
packages 43.18% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

github-actions bot commented Sep 9, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43.3 KB (0%) 866 ms (0%) 520 ms (+18.77% 🔺) 1.4 s
thirdweb (cjs) 100.41 KB (0%) 2.1 s (0%) 832 ms (-14.7% 🔽) 2.9 s
thirdweb (minimal + tree-shaking) 4.82 KB (0%) 97 ms (0%) 48 ms (+40.72% 🔺) 144 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 23 ms (+197.63% 🔺) 33 ms
thirdweb/react (minimal + tree-shaking) 16.67 KB (0%) 334 ms (0%) 97 ms (+36.89% 🔺) 431 ms

Copy link

graphite-app bot commented Sep 10, 2024

Merge activity

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR removes the `favicon.ico` file from the `wallet-ui` app.

### Detailed summary
- Deleted the `favicon.ico` file from the `wallet-ui` app.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground September 10, 2024 01:57 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www September 10, 2024 01:57 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 September 10, 2024 01:57 Inactive
@graphite-app graphite-app bot merged commit eb88ed6 into main Sep 10, 2024
31 checks passed
@graphite-app graphite-app bot deleted the fix/wallet-ui-favicon branch September 10, 2024 02:00
@vercel vercel bot temporarily deployed to Production – docs-v2 September 10, 2024 02:00 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground September 10, 2024 02:00 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb-www September 10, 2024 02:00 Inactive
kien-ngo pushed a commit that referenced this pull request Sep 10, 2024
## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR removes the `favicon.ico` file from the `wallet-ui` app.

### Detailed summary
- Deleted the `favicon.ico` file from the `wallet-ui` app.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants