Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] - unlock node 20 #1628

Merged
merged 2 commits into from
Sep 19, 2023
Merged

[cli] - unlock node 20 #1628

merged 2 commits into from
Sep 19, 2023

Conversation

jnsdls
Copy link
Member

@jnsdls jnsdls commented Sep 19, 2023

Problem solved

allow node 20 users to use our CLI :)

@jnsdls jnsdls requested review from a team as code owners September 19, 2023 06:33
@changeset-bot
Copy link

changeset-bot bot commented Sep 19, 2023

🦋 Changeset detected

Latest commit: 5afe1d5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
thirdweb Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch has no changes to coverable lines.

📢 Thoughts on this report? Let us know!.

@jnsdls jnsdls added this pull request to the merge queue Sep 19, 2023
Merged via the queue into main with commit 710739c Sep 19, 2023
9 checks passed
@jnsdls jnsdls deleted the jd/unlock-node-20-cli branch September 19, 2023 06:42
@github-actions github-actions bot mentioned this pull request Sep 19, 2023
@@ -6,7 +6,7 @@
"author": "thirdweb eng <[email protected]>",
"license": "Apache-2.0",
"engines": {
"node": ">=16.0.0 <19"
"node": ">=16.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jnsdls should this be > 16.0.0 ? based on: #1629

jnsdls pushed a commit that referenced this pull request Jun 19, 2024
feat: notification preferences + onboarding opt-in to email updates

fixes FTD-2101
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants