Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for search within polygon Geoshape #441

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kainosnoema
Copy link

The current version of ElasticSearch supports the GeoPolygonFilter, so it was trivial to add support for polygons with an arbitray number of boundary points. Works great. I added a test and the suite passes.

The trickiest part of this is the interface to easily create a polygon Geoshape with both Java and Groovy syntax. This is where I ended up (seemed consistent with the other constructors), but I'm open to suggestions:

g.V.has('location', WITHIN, Geoshape.polygon(37.0,22.0, 40.0,22.0, 40.0,24.0, 37.0,24.0))

We could support ArrayList<double>(2) arguments to make the Groovy a bit nicer, but it would increase the complexity. Thoughts?

The current version of ElasticSearch supports the GeoPolygonFilter,
so it's trivial to add support for polygons with an arbitray number of
boundary points.

Signed-off-by: Evan Owen <[email protected]>
@kainosnoema
Copy link
Author

I'm not sure exactly why the Travis build is failing, but it doesn't seem to be related to this commit: [INFO] Titan-Lucene: Indexing Support .................... FAILURE [14.386s]. The master branch branch was passing for me locally just fine prior to pushing this. Is this a known issue at the moment?

@mbroecheler
Copy link
Member

Yes, travis is overwhelmed by the complexity of the Titan build and will
fail due to time-outs. We have tried to navigate this by splitting the
build into a small and large build so it can complete on time, but Travis
is very restrictive and the expansion of Titan has caused our test coverage
and therefore unit test time to increase.

On Fri, Oct 18, 2013 at 9:57 PM, Evan Owen [email protected] wrote:

I'm not sure exactly why the Travis build is failing, but it doesn't seem
to be related to this commit: [INFO] Titan-Lucene: Indexing Support
.................... FAILURE [14.386s]. The master branch branch was
passing for me locally just fine prior to pushing this. Is this a known
issue at the moment?


Reply to this email directly or view it on GitHubhttps://github.com//pull/441#issuecomment-26643518
.

Matthias Broecheler
http://www.matthiasb.com

@ghost ghost assigned mbroecheler Oct 24, 2013
@ghost ghost assigned dalaro Jan 15, 2014
@mbroecheler mbroecheler assigned mbroecheler and unassigned dalaro Feb 12, 2014
@mbroecheler mbroecheler modified the milestones: Titan0.6, Titan0.5 Apr 10, 2014
@mbroecheler mbroecheler modified the milestones: Titan1.1, Titan0.5.2 Sep 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants