Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Yobiiq B.V. SD-1001 Smoke Detector template #28

Merged
merged 4 commits into from
Nov 4, 2024

Conversation

dhakke
Copy link
Contributor

@dhakke dhakke commented Nov 1, 2024

No description provided.

@ashvayka ashvayka merged commit b137e3d into thingsboard:main Nov 4, 2024
1 check passed
@ashvayka
Copy link
Member

ashvayka commented Nov 4, 2024

@dhakke Thank you for your contribution! Do you consider adding the converters for electricity metering? Meanwhile I will ask @artem-barysh-dev to improve your converter a bit. We are in progress of creating more precise guidelines for converter development.

@dhakke
Copy link
Contributor Author

dhakke commented Nov 4, 2024

@ashvayka We are in the progress of adding the other device types as well.

@ashvayka
Copy link
Member

ashvayka commented Nov 5, 2024

@dhakke At the moment we are refactoring your converter. Please hold on with other PR's until we will provide an updated version. It will be much easier to extend and support updated version. I believe it will be ready today. One thing to notice is the actual payload decoding. Your sample payload contains "AXVkAgsAAwAABAAABQAABgAA" data. But there is no trace of actual decoding of this data.

@ashvayka
Copy link
Member

ashvayka commented Nov 5, 2024

We need the decoding function to add support of the same device to other integrations (other network server vendors)

@dhakke
Copy link
Contributor Author

dhakke commented Nov 5, 2024

We need the decoding function to add support of the same device to other integrations (other network server vendors)

We are working on adding Things Stack Industries / Community and LorIOT

@ashvayka
Copy link
Member

ashvayka commented Nov 5, 2024

Do you have any documentation on payload data decoding? We were not able to find it on your website

@dhakke
Copy link
Contributor Author

dhakke commented Nov 5, 2024

Do you have any documentation on payload data decoding? We were not able to find it on your website

I have e-mailed you some additional information.

@ashvayka
Copy link
Member

ashvayka commented Nov 5, 2024

Sorry, i don't see any emails from you. Please send it to [email protected] if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants