-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Find a way to let EiE update the data #174
Comments
Short term: until the data can be updated by SYE. EiE will send mySoc a weekly update of changes they know need to be made to the data. Longer term: mySoc to explore the Wikidata/ Commons approach and to coordinate a call between PTCIJ and EiE following a decision on the Concorde Legacy. Georgie to send update on DC and look to get PTCIJ together |
Georgie to bring PTCIJ and SYE together to discuss Data maintenance plans |
Estimate: 5 days. Could point them to existing docs on how to update Wikidata (edit directly). On the other side, could build an entire new tool, but that is verging into an entire new project. |
I originally commented on the wrong issue, oops! #182 (comment) We've just had a call about this. We think there are essentially three approaches we could take: 1. Give them a full editing interface for people and make them a data source
2. Use Wikidata tools and the EveryPolitician data pipeline
3. Maintain a local datasource which overrides certain bits of data
I think that 3. is probably the best trade-off between good UX for EiE and using data from Wikidata. EiE are already sending us bits of data to update. Initially we could have this as just-another-datasource which gets layered on-top of the existing data. Further down the line once we've established the kind of things that they want to update we might be able to translate it to some kind of admin interface. See also follow-up comment from @crowbot #182 (comment), included below for completeness.
|
Additionally, I wonder if we could get a supercheap editing interface via https://help.github.com/articles/rendering-csv-and-tsv-data/ |
If we do #237 first then we'll have a better idea of what's needed for this. |
Since this issue is still opened, has there been any resolve to this? We are currently transitioning government following the concluded elections. How can we edit the peoples' data without worrying for it to be overridden by mySociety's data flow process? |
@EiEResearch We made some progress on this in #269 and #270, which changed the datasource from EveryPolitician to local CSV files stored within this repository. This is a step in the right direction, but currently still requires someone with moderate technical skills to update the CSV files correctly. |
@chrismytton Can this csv update be rolled out to the governors' data-set too? How do we handle assets like images also, I see there is a shineyoureyes-images repo that holds all officials thumbnails. |
@EiEResearch The Governors already come from a CSV file, it's the The shineyoureye-images repository is hosted on GitHub Pages. So any changes made to that repo are automatically deployed to theyworkforyou.github.io/shineyoureye-images. The images were originally generated from EveryPolitician, but the data now comes directly from CSVs, so the script described in the README won't work with new CSV data. This means you'll have to add them manually or using a new script to generate the images into the right place. The repository has a fairly simple layout, the directories are in You should be able to add the new images into the correct directories with the expected names and things will just work…however there is a slight gotcha at the moment, which is that you need to add something in the This is because
And shineyoureye-sinatra/lib/membership_csv/person.rb Lines 28 to 30 in 3d105f8
There might be a nicer way to handle that, but just something to watch out for. |
EiE have asked to be able to update the person data in SYE on a regular basis. The research that Gemma and Bec have done has found situations that back up this need to proactively update the data even if the official data isn't the same.
As these updates may be based on political knowledge but not necessarily anything in a newspaper or on a website - we will need to give clear instructions on how to do this if we expect it to go through wikidata (so that it doesn't get deleted)
The text was updated successfully, but these errors were encountered: