Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Soft dependency on Goalie to avoid duplication #350

Open
jwallwork23 opened this issue Nov 14, 2023 · 0 comments
Open

Soft dependency on Goalie to avoid duplication #350

jwallwork23 opened this issue Nov 14, 2023 · 0 comments

Comments

@jwallwork23
Copy link
Contributor

It does make me wonder, though, whether we should avoid the duplication so this doesn't happen again. We obviously don't want Thetis to depend on Goalie, but maybe we could put something in here so that this part of the code only works if you have Goalie installed and if so imports form2indicator?

Originally posted by @jwallwork23 in #349 (review)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jwallwork23