Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

platform/xtos: remove shim.h interface as it's no longer needed #9461

Merged
merged 7 commits into from
Sep 16, 2024

Conversation

kv2019i
Copy link
Collaborator

@kv2019i kv2019i commented Sep 11, 2024

Series of patches to remove remaining usage of shim.h interface and finally remove the whole interface both from platform and xtos layers.

Link: #9015

The only remaining user of the SOF shim.h platform interface
is Intel Tiger Lake platform. And even for this target, only a very
small part of the interface is used. Everything else is either
not used, and/or moved to Zephyr.

Move the remaining definitions to the Tiger Lake implementation,
allowing the interface to be removed from SOF platform layer.

Signed-off-by: Kai Vehmanen <[email protected]>
Only native Zephyr drivers supported now for Intel cAVS, so dw-dma.h
can be removed. Removing this file allow to remove the SOF shim.h
layer.

Signed-off-by: Kai Vehmanen <[email protected]>
Memory management has been moved to Zephyr for these platforms, so this
file can be removed. Removing this file allow to remove the SOF shim.h
layer.

Signed-off-by: Kai Vehmanen <[email protected]>
Memory power management has been moved to Zephyr for these platforms, so
this file can be removed. Removing this file allow to remove the SOF shim.h
layer.

Signed-off-by: Kai Vehmanen <[email protected]>
All users of shim.h have been either removed and/or moved to
Zephyr, so the interface can be removed from codebase.

Signed-off-by: Kai Vehmanen <[email protected]>
Remove the shim.h interface from RTOS layer as there is no use
of this interface anymore in SOF codebase.

Link: thesofproject#9015
Signed-off-by: Kai Vehmanen <[email protected]>
Fix errors in code documentation to match the implementation.

Signed-off-by: Kai Vehmanen <[email protected]>
@kv2019i
Copy link
Collaborator Author

kv2019i commented Sep 12, 2024

Seems to have hit error in test execution on TGL DUT, but failure seems to be related to getting the test to run "TestLoadFwBasic --platform*TGL' is failed: Test did not even start". @wszypelt can you check?

@kv2019i kv2019i merged commit f39e416 into thesofproject:main Sep 16, 2024
44 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants