app: fix filter in sample.yaml #8768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nxp_adsp_imx8ulp needs to be in allowed platforms. Signed-off-by: Anas Nashif <[email protected]>
nashif
requested review from
lgirdwood,
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
marc-hb
approved these changes
Jan 22, 2024
There was a problem hiding this comment.
@dbaluta and I asked @TangleZ to do this a couple months ago but they never did:
It does not help that SOF and Zephyr are different git repos. This file is in the SOF repo but used only by Zephyr CI. A one-line manifest change is enough to submit a PR in one repo to the CI tests of the other repo but that unfortunately that requires people being interested in getting their code tested :-( zephyrproject-rtos/zephyr#67393 (comment)
btian1
approved these changes
Jan 23, 2024
lgirdwood
approved these changes
Jan 24, 2024
kv2019i
approved these changes
Jan 24, 2024
|
@lgirdwood all green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nxp_adsp_imx8ulp needs to be in allowed platforms.
Signed-off-by: Anas Nashif [email protected]