Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MUX & DEMUX Configuration examples #251

Open
mwasko opened this issue Jun 4, 2020 · 4 comments
Open

Fix MUX & DEMUX Configuration examples #251

mwasko opened this issue Jun 4, 2020 · 4 comments
Assignees
Labels
invalid This doesn't seem right

Comments

@mwasko
Copy link
Contributor

mwasko commented Jun 4, 2020

The example configuration matrix for MUX & DEMUX are invalid.

https://thesofproject.github.io/latest/algos/demux/demux.html

@mwasko mwasko added the invalid This doesn't seem right label Jun 4, 2020
@juimonen
Copy link

juimonen commented Jun 4, 2020

@mwasko you mean because implementation has changed? I can also try to fix this if needed as I did the original...

@mwasko
Copy link
Contributor Author

mwasko commented Jun 4, 2020

@juimonen the current MUX & DEMUX configuration matrix does not seem to make any sense, please take a look at it and let me know.

In MUX configuration example both Input Stream 1 and Stream 2 has channels 1,3,5,7 copied to all 8 output channels. It does not match the description.

@juimonen
Copy link

juimonen commented Jun 4, 2020

@mwasko oh I admit it is quite stupid example of a routing matrix... there's only 2 input/output channels (the red arrows), so essentially everything in the 8x8 matrix that falls out of the 2x2 upper left square is useless i.e. doesn't have any effect. Anyway I think nothing should stop you using this kind of matrix with 2 channel use case and actually you have to define 8x8 in topology even not using all 8 channels.

But yeah, maybe just zero out everything out of 2x2 would make it clear?

@lgirdwood
Copy link
Member

@juimonen @bkokoszx lets roll all our demux/mux fixes up for v1.6. I think we are going in the right direction now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

4 participants