Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASoC: SOF: sof-of-dev: add parameter to override tplg/fw_filename #5205

Merged

Conversation

AnneOnciulescu
Copy link

Add support to override topology and firmware filename, using module parameters. This is helpful for development and also for testing various scenarios.

Add support to override topology and firmware filename,
using module parameters. This is helpful for development
and also for testing various scenarios.

Signed-off-by: Anne Onciulescu <[email protected]>
@sofci
Copy link
Collaborator

sofci commented Oct 11, 2024

Can one of the admins verify this patch?

reply test this please to run this test once

@iuliana-prodan
Copy link

test this please

test this please

Copy link
Collaborator

@ujfalusi ujfalusi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have been thinking of moving these overrides to core.c and mark the options in sof-pci/acpi/of as deprecated.

We have the full set of overrides (including also IPC version) in sof-pci-dev.c only, similar level of override would just duplicate code over time, which does not make much sense.

@bardliao
Copy link
Collaborator

I have been thinking of moving these overrides to core.c and mark the options in sof-pci/acpi/of as deprecated.

We have the full set of overrides (including also IPC version) in sof-pci-dev.c only, similar level of override would just duplicate code over time, which does not make much sense.

Agree, my first thought to this PR is that haven't we done this? Then realized this is for different platforms.

@dbaluta dbaluta merged commit a8cc01c into thesofproject:topic/sof-dev Oct 16, 2024
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants