ASoC: SOF: Deprecate Switch in IPC3 Enums #4475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cujomalainey
requested review from
ranj063,
singalsu,
bardliao and
juimonen
as code owners
bardliao
previously approved these changes
Jul 17, 2023
plbossart
previously approved these changes
Jul 24, 2023
ranj063
previously approved these changes
Jul 24, 2023
plbossart
previously approved these changes
Jul 25, 2023
lyakh
previously approved these changes
Jul 25, 2023
The switch component was never completed and sat half empty for over 3 years. It was recently deleted. For modern components this would require not change in the kernel but since this was a legacy allocation from the enum days of IPC3 we should mark the respective enum as deprecated. The splitter component was never even got a source file in the firmware. Therefore also delete it since this is not needed. Signed-off-by: Curtis Malainey <[email protected]>
cujomalainey
dismissed stale reviews from lyakh, plbossart, and ranj063
via
a3d6408
plbossart
approved these changes
Jul 25, 2023
bardliao
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The switch component was never completed and sat half empty for over 3 years. It was recently deleted. For modern components this would require not change in the kernel but since this was a legacy allocation from the enum days of IPC3 we should mark the respective enum as deprecated.