ASoC: max98357a: handle playback trigger only #4432
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Max98357a supports playback only. However, we may add capture capability in machine driver to use the BE to get the playback data for echo reference. That will introduce an issue that when the capture pcm is closed, the trigger ops will be triggered and power down max98357a. This commit adds a direction test and only handle playback triggers that will fix the issue. Signed-off-by: Bard Liao <[email protected]>
bardliao
requested review from
RanderWang,
naveen-manohar and
ryans-lee
as code owners
|
Great, that we have a fix! A question: why is the codec then triggered when the capture pipeline state changes? Shouldn't that be avoided, and would that be possible? |
|
@lyakh that's because we set the .dpcm_capture flag in the machine driver dailink, but the dai does not support capture. that's really borderline legit. see |
RanderWang
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Max98357a supports playback only. However, we may add capture capability in machine driver to use the BE to get the playback data for echo reference. That will introduce an issue that when the capture pcm is closed, the trigger ops will be triggered and power down max98357a. This commit adds a direction test and only handle playback triggers that will fix the issue.
Fixes: #4431