Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several modifications to dockerfile's ARGs, fixed a bug in the makefile, and updated some docs #43

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

mattaereal
Copy link
Collaborator

Moved all ARGs to the top of the dockerfile. Fixed a bug on the makefile that wasn't getting the arguments propoerly from the .env, and updated some docs.

@reynico
Copy link
Collaborator

reynico commented Oct 16, 2024

seems like gitxray left unconfigured

0.365 Unable to parse package spec: gitxray==

@mattaereal
Copy link
Collaborator Author

Uhm, if gitxray fails, it's because it is not parsing the arguments from the .env. Since it will be the first one to fail.

Haven't looked at the fail log, but I'm positive the action just runs docker buildx build ., and not make build, which made sense up to this PR 😅 .

amirite?

@mattaereal mattaereal merged commit 809acfa into develop Oct 17, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants