Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse plugin manifest to determine minor/major versions #2

Open
thepieterdc opened this issue Jan 30, 2020 · 2 comments
Open

Parse plugin manifest to determine minor/major versions #2

thepieterdc opened this issue Jan 30, 2020 · 2 comments

Comments

@thepieterdc
Copy link
Owner

Inspire by https://github.com/JetBrains/gradle-intellij-plugin/

@halirutan
Copy link

halirutan commented Mar 7, 2020

This is a good idea.

Additionally, you could make a default that builds the name of the plugin.zip automatically. You get the version number, the since/until build, and the plugin name from the build/patchedPluginXmlFiles/plugin.xml. For many plugins, you could then determine the required plugin setting yourself which has the vast advantage that developers don't need to change main.yml every time they push a new version.

With this, your action would per default just work without any adjustments. You know the plugin.zip filename and you know the min and max version to test against. If the developer wants something different, he can manually set plugin and versions.

Great job by the way! Just set it up for the Key Promoter X

@thepieterdc
Copy link
Owner Author

thepieterdc commented Mar 7, 2020

Additionally, you could make a default that builds the name of the plugin.zip automatically.

I will include this in the README I have updated the readme, I actually use it myself like this, not requiring a change after every new version:

with:
  plugin: '/home/runner/work/plugin-name/plugin-name/build/distributions/plugin-name-*'

You get the version number, the since/until build, and the plugin name from the build/patchedPluginXmlFiles/plugin.xml.

I was indeed planning to change the required options and require the user to specify the path to their build/ folder, that way I can indeed parse plugin.xml to get the name of the zip file and the versions.

Great job by the way! Just set it up for the Key Promoter X

Great to hear!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants