Does directory_visibility have precedence over visibility when creating a directory

[theodson]

is it correct to assume directory_visibility have precedence over visibility when creating a directory

Q	A
Flysystem Version	3.2.x
Adapter Name	src/Local/LocalFilesystemAdapter.php
Adapter version	x.y.z

The current implementation seems counter intuitive to me, e.g. consider the src/Local/LocalFilesystemAdapterTest.php

$adapter->createDirectory('public_dir_private_files', new Config(['visibility' => 'private', 'directory_visibility' => 'public']));
$this->assertDirectoryExists(static::ROOT . '/public_dir_private_files');
$this->assertFileHasPermissions(static::ROOT . '/public_dir_private_files', 0700); 

The assertion of 0700 permissions for the directory seems odd/incorrect, should this not be 0755 given we pass directory_visibility=public

I've added two commits to this branch tests_confirming_directory_visibility_behaviour

1. the 1st commit adds more tests around file and directory permission checks adhering to the existing implementation.
2. the 2nd commit changed the precedence of the directory_visibility over visibility in the context of $adapter->createDirectory

See diff 3.x...theodson:flysystem:tests_confirming_directory_visibility_behaviour

Ref

• https://flysystem.thephpleague.com/docs/usage/filesystem-api/
• https://flysystem.thephpleague.com/docs/usage/unix-visibility/
• https://flysystem.thephpleague.com/docs/visibility/