Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error notification build up and crash #9

Open
akinsho opened this issue Nov 17, 2020 · 1 comment
Open

Error notification build up and crash #9

akinsho opened this issue Nov 17, 2020 · 1 comment
Assignees

Comments

@akinsho
Copy link

akinsho commented Nov 17, 2020

Describe the bug
I've noticed whilst using this plugin that if you have an error that repeats imagine the infamous column sizing error, this extension continuously creates floating windows which slowly swallow up the right hand side of the editor up till it neovim crashes. I believe the crash is probably an upstream issue in neovim, but even without the crash I think that many notifications isn't really helpful especially if its a recurrent problem in your code you are trying to fix.

This is pretty similar to the original issue in coc-flutter the main difference being in that extension the windows are suppressed although the bug is not tbh, you still get nvim_win api call errors.

To Reproduce
Steps to reproduce the behavior:

  • Trigger a repeated error in your project such as the incoming vertical constraints are unbounded
    error.
  • have the app hot reload by making changes, that don't fix the error.
  • see the notifications pile up

Expected behavior

  • I think notifications should be either debounced or toggleable or new errors notifications should clear the previous ones first. Ultimately if I'm being warned of the same error like 20 times a minute I don't need 20 notifications.

Screenshots
Will post some when next this occurs (currently at work)

Desktop (please complete the following information):

  • OS: MacOS
  • Vim or Neovim: Neovim
  • (Neo)vim version: NVIM v0.5.0-nightly-207-g1b8867ab39

Output channel:

  1. Set "flutter.trace.server": "verbose"
  2. Reproduce the issue
  3. :CocList output open output list and select flutter

Log:

@theniceboy theniceboy self-assigned this Nov 17, 2020
@theniceboy
Copy link
Owner

Thank you for this comprehensive issue report! I'll work on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants