Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(peer)depedency now missing from the package.json? #106

Open
jcompagner opened this issue Oct 4, 2021 · 3 comments
Open

(peer)depedency now missing from the package.json? #106

jcompagner opened this issue Oct 4, 2021 · 3 comments

Comments

@jcompagner
Copy link

With the new release 2.5.0 we suddenly have:

An error occurred during the build:
Error: The target entry-point "ngx-lightbox" has missing dependencies:

  • ngx-filesaver

because of the pull:

https://github.com/themyth92/ngx-lightbox/pull/103/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R28

I know i can fix this by also including that one in our build, but that is a bit annoying, currently our builds are broken because of the above thing if we just install 2.5.0 version of lightbox.

@jcompagner
Copy link
Author

and if you then just install ngx-filesaver you get:

✖ Compiling with Angular sources in Ivy partial compilation mode.
node_modules/ngx-filesaver/src/filesaver.service.d.ts:1:34 - error TS2307: Cannot find module 'file-saver' or its corresponding type declarations.

1 import { FileSaverOptions } from 'file-saver';
~~~~~~~~~~~~
node_modules/ngx-filesaver/src/filesaver.directive.d.ts:4:34 - error TS2307: Cannot find module 'file-saver' or its corresponding type declarations.

4 import { FileSaverOptions } from 'file-saver';
~~~~~~~~~~~~

@themyth92
Copy link
Owner

Sorry can u try to install file-saver and ngx-filesaver first. I will need to add both to the peer-denpendancy later

@themyth92
Copy link
Owner

Or just use 2.4.1 for now. That version is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants