fix the issue #973 #983
Merged
fix the issue #973 #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dear @zoltanszogyenyi |
|
Original, it will show like the below Screenshots Screen.Recording.2024-10-16.at.10.29.31.pm.mov |
|
This is a good fix for an edge case. Thanks for contributing! <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
WYSIWYG: When text is set to bold, it is not possible to change its color. #973
Pull Request Description
Summary
This pull request addresses the issue #973 where, after applying bold formatting to text in the WYSIWYG editor, users were unable to change the color of the bolded text.
Changes Made
Updated the text formatting logic to allow color changes to be applied to bolded text.
Ensured that the editor state correctly reflects both the bold and color attributes simultaneously.
Steps to Test
1.Open the WYSIWYG text editor.
2.Select some text and click the Bold button to apply bold formatting.
3.Then select the same text, click the Text Color button, and choose a color.
4.Verify that the text remains bold while the selected color is applied.
5.This fix ensures that users can now change the color of bold text without losing the bold formatting.
Outcome Screenshots
Screen.Recording.2024-10-16.at.9.50.20.pm.mov
Additional note
1.This modification allows the text font to change its color while being bold, fixing the previous bug
2.Please review the changes and let me know if any further modifications are needed.
Thank you for considering this update!