New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect message names outside of 1962 #10

Open

Xsear opened this issue Feb 25, 2024 · 0 comments

Collaborator

Xsear commented Feb 25, 2024

PacketPeep always defaults to 1962 protocol data and thus message names will be inaccurate if you load replays or captures from other versions.
https://github.com/themeldingwars/PacketPeep/blob/main/PacketPeep/Systems/PacketDB.cs#L24C38-L24C59
There is a warning about this in logs but its easy to miss as they are sent before all the parsing errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment