SDB Writing #2
Closed
SDB Writing #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented Write method of StaticDB.
This probably needs a sanity check for code quality, but the added tests work on 1962.
The written files are accepted both by SDBrowser, and the game seems to be fine with mods and additions, as long as new rows follow the expected index order of that table.
Reading and parsing the original database does not produce 100% identical output, with some difference in the keyed data section, and minor diff in the deflated output.
I did not perfectly implement the generation of the keys for the data section, see the function GenerateDataEntryKey. I verified that the alternate version produced the expected keys for two data points, but when put in use I ended up with garbled output for many values (but not all), particularly in the localization table.