Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locally hosted 'video' breaks preview and build #958

Open
1 task done
brutaldigital opened this issue Oct 4, 2024 · 0 comments
Open
1 task done

Locally hosted 'video' breaks preview and build #958

brutaldigital opened this issue Oct 4, 2024 · 0 comments
Assignees
Labels
status:triage needed Issue needs to be triaged by the Quire team. This label is automatically applied to new issues.

Comments

@brutaldigital
Copy link

Before proceeding, make sure there isn’t an existing issue for this bug.

  • I have searched the existing issues and determined this is a new bug.

Expected Behavior

Along with Vimeo and YouTube videos, Quire can also support video that you include directly in your project.

Actual Behavior

Quire preview and build fails without an error message.

Steps to Reproduce

Add figure entry following Quire v1.0 guidance:

- id: vid-2
  poster: video-2-still.jpg
  src: my-video-file.mp4
  media_type: video

Run quire preview in Terminal

Version Numbers

quire-cli 1.0.0-rc.11
quire-11ty 1.0.0-rc.16
starter https://github.com/thegetty/[email protected]
[System]
quire-cli 1.0.0-rc.15
node v20.16.0
npm 10.8.1
os Darwin 23.6.0

Web Browser

Chrome 129 on macOS (Sonoma)
https://whatismybrowser.com/w/NSK4TML

Relevant Terminal/Shell Output

[11ty] Problem writing Eleventy templates: (more in DEBUG output)
[11ty] Cannot read properties of undefined (reading 'output') (via TypeError)
[11ty] 
[11ty] Original error stack trace: TypeError: Cannot read properties of undefined (reading 'output')
[11ty]     at get staticInlineFigureImage [as staticInlineFigureImage] (/Users/thomasscutt/GitHub/britishartstudies-26/_plugins/figures/figure/index.js:218:87)
[11ty]     at Figure.adapter (/Users/thomasscutt/GitHub/britishartstudies-26/_plugins/figures/figure/index.js:251:37)
[11ty]     at /Users/thomasscutt/GitHub/britishartstudies-26/_plugins/figures/index.js:46:42
[11ty]     at Array.map (<anonymous>)
[11ty]     at AsyncEventEmitter.<anonymous> (/Users/thomasscutt/GitHub/britishartstudies-26/_plugins/figures/index.js:46:15)
[11ty]     at async Promise.all (index 1)
[11ty]     at async Eleventy.executeBuild (/Users/thomasscutt/GitHub/britishartstudies-26/node_modules/@11ty/eleventy/src/Eleventy.js:1176:7)
[11ty]     at async Eleventy.watch (/Users/thomasscutt/GitHub/britishartstudies-26/node_modules/@11ty/eleventy/src/Eleventy.js:1014:18)
[11ty] Wrote 0 files in 0.18 seconds (v2.0.1)

Supporting Information

Commenting out the media_type and src corrects the issue.

@brutaldigital brutaldigital added the status:triage needed Issue needs to be triaged by the Quire team. This label is automatically applied to new issues. label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:triage needed Issue needs to be triaged by the Quire team. This label is automatically applied to new issues.
Projects
None yet
Development

No branches or pull requests

2 participants